chrome/common/cloud_print/cloud_print_cdd_conversion.cc - Issue 334763002: Add paper size reporting for CUPS printers (to let user to select one in the Print Preview).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/cloud_print/cloud_print_cdd_conversion.cc

Issue 334763002: Add paper size reporting for CUPS printers (to let user to select one in the Print Preview). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add unit test for PPD page size extraction, log error on PPD file opening, address other cl comment… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/cloud_print/cloud_print_cdd_conversion.cc

diff --git a/chrome/common/cloud_print/cloud_print_cdd_conversion.cc b/chrome/common/cloud_print/cloud_print_cdd_conversion.cc

index b485cffbd76bd465a79d417c14b9c7ffd840d0a1..70c774d9fdfd3fc1a507f59cc6b1d22398af652e 100644

--- a/chrome/common/cloud_print/cloud_print_cdd_conversion.cc

+++ b/chrome/common/cloud_print/cloud_print_cdd_conversion.cc

@@ -55,8 +55,8 @@ scoped_ptr<base::DictionaryValue> PrinterSemanticCapsAndDefaultsToCdd(

color.SaveTo(&description);

if (!semantic_info.papers.empty()) {

- Media default_media(semantic_info.default_paper.name,

- "",

+ Media default_media(semantic_info.default_paper.display_name,

+ semantic_info.default_paper.vendor_id,

semantic_info.default_paper.size_um.width(),

semantic_info.default_paper.size_um.height());

default_media.MatchBySize();

@@ -67,8 +67,8 @@ scoped_ptr<base::DictionaryValue> PrinterSemanticCapsAndDefaultsToCdd(

gfx::Size paper_size = semantic_info.papers[i].size_um;

if (paper_size.width() > paper_size.height())

paper_size.SetSize(paper_size.height(), paper_size.width());

- Media new_media(semantic_info.papers[i].name,

- "",

+ Media new_media(semantic_info.papers[i].display_name,

+ semantic_info.papers[i].vendor_id,

paper_size.width(),

paper_size.height());

new_media.MatchBySize();

« no previous file with comments | « chrome/common/chrome_utility_messages.h ('k') | printing/backend/cups_helper.cc » ('j') | no next file with comments »