content/common/media/aec_dump_messages.h - Issue 334743006: Support multiple files for AEC dump.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/media/aec_dump_messages.h

Issue 334743006: Support multiple files for AEC dump. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review (sky). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/media/webrtc_browsertest.cc ('K') | « content/common/content_message_generator.h ('k') | content/common/media/media_stream_messages.h » ('j') | content/renderer/media/aec_dump_message_filter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
	no longer working on chromium 2014/06/16 18:30:55 ditto ditto Henrik Grunell 2014/06/17 20:21:41 Done. Show quoted text On 2014/06/16 18:30:55, xians1 wrote: > ditto Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for the AEC dump.

	6 // Multiply-included message file, hence no include guard.

	7

	8 //#include "base/basictypes.h"
	no longer working on chromium 2014/06/16 18:30:55 ?? ?? Henrik Grunell 2014/06/17 20:21:41 Removed. Show quoted text On 2014/06/16 18:30:55, xians1 wrote: > ?? Removed.
	9 //#include "base/sync_socket.h"

	10 #include "content/common/content_export.h"

	11 #include "ipc/ipc_message_macros.h"

	12 #include "ipc/ipc_platform_file.h"

	13

	14 #undef IPC_MESSAGE_EXPORT
	no longer working on chromium 2014/06/16 18:30:55 ?? add comment if it is required. ?? add comment if it is required. Henrik Grunell 2014/06/17 20:21:41 Well, it's there in all other messages.h files in Show quoted text On 2014/06/16 18:30:55, xians1 wrote: > ?? add comment if it is required. Well, it's there in all other messages.h files in this folder at least. Without comments. I'm assuming it's needed for certain build cases.
	15 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

	16 #define IPC_MESSAGE_START AecDumpMsgStart
	no longer working on chromium 2014/06/16 18:30:55 ditto ditto Henrik Grunell 2014/06/17 20:21:41 ditto Show quoted text On 2014/06/16 18:30:55, xians1 wrote: > ditto ditto
	17

	18 // Messages sent from the browser to the renderer.

	19

	20 // The browser hands over a file handle to the consumer in the renderer

	21 // identified by \|id\| to use for AEC dump.

	22 IPC_MESSAGE_CONTROL2(AecDumpMsg_EnableAecDump,

	23 int /* id */,

	24 IPC::PlatformFileForTransit /* file_handle */)

	25

	26 // Tell the renderer to disable AEC dump in all consumers.

	27 IPC_MESSAGE_CONTROL0(AecDumpMsg_DisableAecDump)

	28

	29 // Messages sent from the renderer to the browser.

	30

	31 // Registers a consumer with the browser. The consumer will then get a file

	32 // handle when the dump is enabled.

	33 IPC_MESSAGE_CONTROL1(AecDumpMsg_RegisterAecDumpConsumer,

	34 int /* id */)

	35

	36 // Unregisters a consumer with the browser.

	37 IPC_MESSAGE_CONTROL1(AecDumpMsg_UnregisterAecDumpConsumer,

	38 int /* id */)

OLD	NEW