Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 334743002: Revert of Revert of Remove now obsolete checkdeps copy (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Revert of Remove now obsolete checkdeps copy (https://codereview.chromium.org/320043002/) Reason for revert: should be safe to land now Original issue's description: > Revert of Remove now obsolete checkdeps copy (https://codereview.chromium.org/307333003/) > > Reason for revert: > Still referenced from blink > > Original issue's description: > > Remove now obsolete checkdeps copy > > > > BUG=none > > R=brettw@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275419 > > TBR=brettw@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275482 TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1951 lines) Patch
D tools/checkdeps/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/checkdeps/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D tools/checkdeps/PRESUBMIT.py View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/checkdeps/builddeps.py View 1 chunk +0 lines, -375 lines 0 comments Download
D tools/checkdeps/checkdeps.py View 1 chunk +0 lines, -237 lines 0 comments Download
D tools/checkdeps/checkdeps_test.py View 1 chunk +0 lines, -177 lines 0 comments Download
D tools/checkdeps/cpp_checker.py View 1 chunk +0 lines, -113 lines 0 comments Download
D tools/checkdeps/graphdeps.py View 1 chunk +0 lines, -407 lines 0 comments Download
D tools/checkdeps/java_checker.py View 1 chunk +0 lines, -107 lines 0 comments Download
D tools/checkdeps/results.py View 1 chunk +0 lines, -178 lines 0 comments Download
D tools/checkdeps/rules.py View 1 chunk +0 lines, -178 lines 0 comments Download
D tools/checkdeps/testdata/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/checkdeps/testdata/allowed/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/checkdeps/testdata/allowed/foo_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/allowed/not_a_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/allowed/test.h View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/allowed/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/allowed/foo_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/allowed/not_a_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/allowed/test.h View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/skipped/test.h View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/disallowed/allowed/test.h View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/checkdeps/testdata/checkdeps_test/disallowed/test.h View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/checkdeps/testdata/disallowed/allowed/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/checkdeps/testdata/disallowed/allowed/skipped/test.h View 1 chunk +0 lines, -5 lines 0 comments Download
D tools/checkdeps/testdata/disallowed/allowed/test.h View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/checkdeps/testdata/disallowed/foo_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/checkdeps/testdata/disallowed/test.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert of Remove now obsolete checkdeps copy
6 years, 6 months ago (2014-06-12 17:29:34 UTC) #1
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-12 17:38:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/334743002/1
6 years, 6 months ago (2014-06-12 17:40:58 UTC) #3
commit-bot: I haz the power
Change committed as 276734
6 years, 6 months ago (2014-06-12 17:44:27 UTC) #4
Feng Qian
6 years, 6 months ago (2014-06-14 06:52:26 UTC) #5
Message was sent while issue was closed.
On 2014/06/12 17:44:27, I haz the power (commit-bot) wrote:
> Change committed as 276734

clang-builder seems using tools/checkdeps/.
https://uberchromegw.corp.google.com/i/clank/builders/clang-builder/builds/4973

Powered by Google App Engine
This is Rietveld 408576698