Issue 334723005: Organize file lists in chrome_browser_ui.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334723005: Organize file lists in chrome_browser_ui.gypi (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Organize file lists in chrome_browser_ui.gypi The main change is that there are no longer any ChromeOS exclusion lists. It also cleans up the definition of all_list in common.gypi now that Linux assume aura. TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280495

Patch Set 1 #

Patch Set 2 : add missing #

Patch Set 3 : fgix win #

Patch Set 4 : chromeos #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+652 lines, -653 lines)			Patch
	M	build/common.gypi	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	chrome/chrome_browser_ui.gypi	View	1 2 3	19 chunks	+650 lines, -650 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Forgot to push send in this review. Going to TBR before I get a bunch ...

6 years, 5 months ago (2014-06-28 05:36:28 UTC) #1

brettw

Committed patchset #4 manually as r280495 (presubmit successful).

6 years, 5 months ago (2014-06-28 05:36:56 UTC) #2

Lei Zhang

6 years, 5 months ago (2014-06-28 06:32:10 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/334723005/diff/60001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/334723005/diff/60001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:1136: # views-specifi app list files are in the
views section.
typo

Expand Messages | Collapse Messages