Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: bench/gen_bench_expectations.py

Issue 334673002: Revert trigger changes (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_expectations.py
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index 674309de83ac68f20e4b91ac0d24cee9b43db32e..a6f96059b6fc353e2bb00322fd8b4d166c60d6d0 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -46,14 +46,12 @@ def compute_ranges(benches):
Returns:
a list of float [lower_bound, upper_bound].
"""
- avg = sum(benches) / len(benches)
- squared_avg = avg ** 2
- avg_sum_squared = sum([bench**2 for bench in benches])/len(benches)
- std_dev = (abs(avg_sum_squared - squared_avg) + 0.0001*abs(avg**2)) ** 0.5
-
- # If the results are normally distributed, 2 standard deviations
- # captures something like ~95% of the possible range of results I think
- return [avg - 2*std_dev, avg + 2*std_dev]
+ avg = sum(benches)/len(benches)
+ minimum = min(benches)
+ maximum = max(benches)
+
+ return [minimum - diff*RANGE_RATIO_LOWER - avg*ERR_RATIO - ERR_LB,
+ maximum + diff*RANGE_RATIO_UPPER + avg*ERR_RATIO + ERR_UB]
def create_expectations_dict(revision_data_points, builder):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698