Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 334653006: mac: Prevent Address Book permissions dialog from erroneously appearing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9f0f16be938fb82af21bb52fbf60ef9e2a80baa5..4a1a7b3918ecac46684aa56d55e33afb7d6048f8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -1545,6 +1545,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Autofill.AddressBook.AccessSkipped" enum="BooleanSkipped">
+ <owner>erikchen@chromium.org</owner>
+ <summary>
+ Whether an attempt to access the Mac AddressBook was skipped because doing
+ so would incorrectly cause the appearance of the permissions dialog. This
+ happens when Chrome auto-update changes the binary on disk before the first
+ AddressBook access attempt.
+ </summary>
+</histogram>
+
<histogram name="Autofill.AddressBookAvailable" enum="BooleanAvailable">
<owner>isherman@chromium.org</owner>
<summary>
@@ -33636,6 +33646,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="1" label="Selected"/>
</enum>
+<enum name="BooleanSkipped" type="int">
+ <int value="0" label="Not skipped"/>
+ <int value="1" label="Skipped"/>
+</enum>
+
<enum name="BooleanStale" type="int">
<int value="0" label="Fresh"/>
<int value="1" label="Stale"/>

Powered by Google App Engine
This is Rietveld 408576698