Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 9f0f16be938fb82af21bb52fbf60ef9e2a80baa5..7b5303159a653e63c551384cdaf63ab352d7959b 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -1562,6 +1562,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Autofill.AddressBookReprompt" enum="BooleanAvailable"> |
|
Ilya Sherman
2014/06/17 19:55:01
Let's name the histogram something more like "Auto
Ilya Sherman
2014/06/17 19:55:01
nit: Please use a more custom-tailored enum, possi
erikchen
2014/06/17 22:36:06
I used "Autofill.AddressBook.AccessSkipped"
erikchen
2014/06/17 22:36:06
I used a new enum BooleanSkipped
|
| + <owner>erikchen@chromium.org</owner> |
| + <summary> |
| + Whether an attempt to access the Mac AddressBook was skipped because doing |
| + so would incorrectly cause the appearance of the permissions dialog. |
|
Ilya Sherman
2014/06/17 19:55:01
Please go into a bit more detail as to why this mi
erikchen
2014/06/17 22:36:06
I've expanded the comment.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Autofill.AddressSuggestionsCount"> |
| <owner>isherman@chromium.org</owner> |
| <summary> |