tools/metrics/histograms/histograms.xml - Issue 334653006: mac: Prevent Address Book permissions dialog from erroneously appearing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 334653006: mac: Prevent Address Book permissions dialog from erroneously appearing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to isherman comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 9f0f16be938fb82af21bb52fbf60ef9e2a80baa5..7b5303159a653e63c551384cdaf63ab352d7959b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -1562,6 +1562,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Autofill.AddressBookReprompt" enum="BooleanAvailable">

Ilya Sherman 2014/06/17 19:55:01 Let's name the histogram something more like "Auto

Ilya Sherman 2014/06/17 19:55:01 nit: Please use a more custom-tailored enum, possi

erikchen 2014/06/17 22:36:06 I used "Autofill.AddressBook.AccessSkipped"

erikchen 2014/06/17 22:36:06 I used a new enum BooleanSkipped

+ <owner>erikchen@chromium.org</owner>

+ <summary>

+ Whether an attempt to access the Mac AddressBook was skipped because doing

+ so would incorrectly cause the appearance of the permissions dialog.

Ilya Sherman 2014/06/17 19:55:01 Please go into a bit more detail as to why this mi

erikchen 2014/06/17 22:36:06 I've expanded the comment.

+ </summary>

+</histogram>

<owner>isherman@chromium.org</owner>

« components/autofill/core/browser/personal_data_manager_mac.mm ('K') | « components/autofill/core/browser/personal_data_manager_mac.mm ('k') | no next file » | no next file with comments »