mac: Prevent Address Book permissions dialog from erroneously appearing.

chrome/browser/mac/keystone_glue.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_
 #define CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_
 
 #include "base/strings/string16.h"
 
 #if defined(__OBJC__)
-
 #import <Foundation/Foundation.h>
 
 #include "base/mac/scoped_authorizationref.h"
 #import "base/mac/scoped_nsobject.h"
+#endif  // __OBJC__

[Ilya Sherman, 2014/06/14 01:18:51]

Why is this header ever included on non-Mac platforms?

[erikchen, 2014/06/16 20:30:46]

I don't know?

 
+namespace keystone_glue {

[Ilya Sherman, 2014/06/14 01:18:51]

Why is this namespace needed?

[Ilya Sherman, 2014/06/14 01:18:51]

nit: Please leave a blank line after this one...

[erikchen, 2014/06/16 20:30:46]

Done (adding vertical whitespace). I could not find a style guideline that
explicitly states this, and the Chrome codebase is certainly not consistent
about this.

[erikchen, 2014/06/16 20:30:46]

I was under the impression that there is a style guideline that enums should
never be released into the global namespace. Looking through Google/Chromium
style guides, I could not find this statement, but I still think its good
practice.

 // Possible outcomes of various operations.  A version may accompany some of
 // these, but beware: a version is never required.  For statuses that can be
 // accompanied by a version, the comment indicates what version is referenced.
 // A notification posted containing an asynchronous status will always be
 // followed by a notification with a terminal status.
 enum AutoupdateStatus {
   kAutoupdateNone = 0,        // no version (initial state only)
   kAutoupdateRegistering,     // no version (asynchronous operation in progress)
   kAutoupdateRegistered,      // no version
   kAutoupdateChecking,        // no version (asynchronous operation in progress)
   kAutoupdateCurrent,         // version of the running application
   kAutoupdateAvailable,       // version of the update that is available
   kAutoupdateInstalling,      // no version (asynchronous operation in progress)
   kAutoupdateInstalled,       // version of the update that was installed
   kAutoupdatePromoting,       // no version (asynchronous operation in progress)
   kAutoupdatePromoted,        // no version
   kAutoupdateRegisterFailed,  // no version
   kAutoupdateCheckFailed,     // no version
   kAutoupdateInstallFailed,   // no version
   kAutoupdatePromoteFailed,   // no version
   kAutoupdateNeedsPromotion,  // no version
 };
+}  // namespace keystone_glue

[Ilya Sherman, 2014/06/14 01:18:51]

nit: ... and before this one.

[erikchen, 2014/06/16 20:30:46]

Done.

+
+#if defined(__OBJC__)
 
 // kAutoupdateStatusNotification is the name of the notification posted when
-// -checkForUpdate and -installUpdate complete.  This notification will be
-// sent with with its sender object set to the KeystoneGlue instance sending
-// the notification.  Its userInfo dictionary will contain an AutoupdateStatus
+// -checkForUpdate and -installUpdate complete.  This notification will be sent
+// with with its sender object set to the KeystoneGlue instance sending the
+// notification.  Its userInfo dictionary will contain an AutoupdateStatus
 // value as an intValue at key kAutoupdateStatusStatus.  If a version is
 // available (see AutoupdateStatus), it will be present at key
-// kAutoupdateStatusVersion.
+// kAutoupdateStatusVersion. This notification is always posted on the main
+// thread.
 extern NSString* const kAutoupdateStatusNotification;
 extern NSString* const kAutoupdateStatusStatus;
 extern NSString* const kAutoupdateStatusVersion;
 
 namespace {
 
 enum BrandFileType {
   kBrandFileTypeNotDetermined = 0,
   kBrandFileTypeNone,
   kBrandFileTypeUser,
@@ skipping 58 matching lines @@
 // a kAutoupdateStatusNotification notification, and will also be available
 // through -recentNotification.
 - (void)checkForUpdate;
 - (void)installUpdate;
 
 // Accessor for recentNotification_.  Returns an autoreleased NSNotification.
 - (NSNotification*)recentNotification;
 
 // Accessor for the kAutoupdateStatusStatus field of recentNotification_'s
 // userInfo dictionary.
-- (AutoupdateStatus)recentStatus;
+- (keystone_glue::AutoupdateStatus)recentStatus;
 
 // Returns YES if an asynchronous operation is pending: if an update check or
 // installation attempt is currently in progress.
 - (BOOL)asyncOperationPending;
 
 // Returns YES if the application is running from a read-only filesystem,
 // such as a disk image.
 - (BOOL)isOnReadOnlyFilesystem;
 
 // -needsPromotion is YES if the application needs its ticket promoted to
@@ skipping 69 matching lines @@
 
 // True if Keystone is enabled.
 bool KeystoneEnabled();
 
 // The version of the application currently installed on disk.
 base::string16 CurrentlyInstalledVersion();
 
 }  // namespace keystone_glue
 
 #endif  // CHROME_BROWSER_MAC_KEYSTONE_GLUE_H_