mac: Prevent Address Book permissions dialog from erroneously appearing.

chrome/browser/autofill/autofill_keystone_observer_mac.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_KEYSTONE_OBSERVER_MAC_H_
+#define CHROME_BROWSER_AUTOFILL_AUTOFILL_KEYSTONE_OBSERVER_MAC_H_
+
+#include "base/mac/scoped_nsobject.h"
+
+@class AutofillKeystoneBridge;
+
+class AutofillKeystoneObserverMacDelegate;
+
+namespace autofill {
+
+// Passes Cocoa based Keystone NSNotifications to its C++ delegate.
+class AutofillKeystoneObserverMac {
+ public:
+  AutofillKeystoneObserverMac(AutofillKeystoneObserverMacDelegate* delegate);

[Ilya Sherman, 2014/06/14 01:18:50]

Please document lifetime expectations.  (It seems that you are expecting that
the |delegate| is guaranteed to outlive the observer?)

[erikchen, 2014/06/16 20:30:45]

I've added the lifetime expectation to the comment at the top of the class.

+  ~AutofillKeystoneObserverMac();
+
+ private:
+  base::scoped_nsobject<AutofillKeystoneBridge> bridge_;
+};

[Ilya Sherman, 2014/06/14 01:18:50]

I'm noticing that you're adding four new files for something that seems pretty
simple.  Do we really need such a refined class hierarchy?  Could the
ChromeAutofillClient class just own a new member variable, and that new class
implement all of the relevant functionality?  That would be a simpler design,
IMO.

[erikchen, 2014/06/16 20:30:45]

Your suggestion is implementable, but it does not significantly reduce the
number of lines added to chrome_autofill_client.{h,cc}, and also does not
significantly reduce the number of new classes. The organization of the new code
in this CL is convoluted because I need to call Obj-C code from/into
chrome_autofill_client, which is compiled in c++. Let me know if you want a more
detailed explanation.

[Ilya Sherman, 2014/06/17 03:29:16]

Here's a more complete implementation along the lines of what I was thinking:
https://codereview.chromium.org/339053003

[erikchen, 2014/06/17 18:14:27]

:O
Your implementation is much cleaner and shorter. I've applied it with minimal
modifications to my CL. Thanks!

+
+}  // namespace autofill
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_KEYSTONE_OBSERVER_MAC_H_