Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 334633010: GN: Only have one gfx_x11 target (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, tfarina, sadrul
Project:
chromium
Visibility:
Public.

Description

GN: Only have one gfx_x11 target I don't think we need two of these and in the component build since they both attempt to produce libgfx_x11.so this produces ninja warnings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279159

Patch Set 1 #

Patch Set 2 : add comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -28 lines) Patch
M ui/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +1 line, -26 lines 0 comments Download
M ui/gfx/x/BUILD.gn View 1 1 chunk +1 line, -0 lines 1 comment Download
M ui/gfx/x/gfx_x11.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
jamesr
6 years, 6 months ago (2014-06-21 00:45:47 UTC) #1
brettw
CAn you add a commnent in the gfx_x11.gyp file giving the path to the GN ...
6 years, 6 months ago (2014-06-21 00:51:39 UTC) #2
brettw
lgtm
6 years, 6 months ago (2014-06-21 00:51:42 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-21 00:55:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/334633010/20001
6 years, 6 months ago (2014-06-21 01:09:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 07:11:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 07:14:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75390)
6 years, 6 months ago (2014-06-21 07:14:23 UTC) #8
jamesr
+ben for OWNERS
6 years, 6 months ago (2014-06-23 18:01:55 UTC) #9
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-23 18:20:32 UTC) #10
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-23 18:20:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/334633010/20001
6 years, 6 months ago (2014-06-23 18:21:46 UTC) #12
commit-bot: I haz the power
Change committed as 279159
6 years, 6 months ago (2014-06-23 19:17:53 UTC) #13
tfarina
6 years, 5 months ago (2014-06-25 22:42:44 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/334633010/diff/20001/ui/gfx/x/BUILD.gn
File ui/gfx/x/BUILD.gn (right):

https://codereview.chromium.org/334633010/diff/20001/ui/gfx/x/BUILD.gn#newcode5
ui/gfx/x/BUILD.gn:5: # GYP version: //ui/gfx/gfx_x11.gyp:gfx_x11
the path should be ui/gfx/x/gfx_x11.gyp

Powered by Google App Engine
This is Rietveld 408576698