Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/diagnostics/diagnostics_controller.cc

Issue 334633006: Remove recovery diagnostics for the archived history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Skip reporting baseline metrics for archived database. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/diagnostics/diagnostics_controller.h" 5 #include "chrome/browser/diagnostics/diagnostics_controller.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 void DiagnosticsController::RecordRegularStartup() { 43 void DiagnosticsController::RecordRegularStartup() {
44 #if defined(OS_CHROMEOS) // Only collecting UMA stats on ChromeOS 44 #if defined(OS_CHROMEOS) // Only collecting UMA stats on ChromeOS
45 // Count the number of normal starts, so we can compare that with the number 45 // Count the number of normal starts, so we can compare that with the number
46 // of recovery runs to get a percentage. 46 // of recovery runs to get a percentage.
47 UMA_HISTOGRAM_ENUMERATION( 47 UMA_HISTOGRAM_ENUMERATION(
48 "Diagnostics.RecoveryRun", RECOVERY_NOT_RUN, RECOVERY_RUN_METRICS_COUNT); 48 "Diagnostics.RecoveryRun", RECOVERY_NOT_RUN, RECOVERY_RUN_METRICS_COUNT);
49 49
50 // For each of the test types, record a normal start (no diagnostics run), so 50 // For each of the test types, record a normal start (no diagnostics run), so
51 // we have a common denominator. 51 // we have a common denominator.
52 for (int i = 0; i < DIAGNOSTICS_TEST_ID_COUNT; ++i) { 52 for (int i = 0; i < DIAGNOSTICS_TEST_ID_COUNT; ++i) {
53 if (static_cast<DiagnosticsTestId>(i) ==
54 DIAGNOSTICS_SQLITE_INTEGRITY_ARCHIVED_HISTORY_TEST_OBSOLETE)
55 continue;
56
53 RecordUMARecoveryResult(static_cast<DiagnosticsTestId>(i), RESULT_NOT_RUN); 57 RecordUMARecoveryResult(static_cast<DiagnosticsTestId>(i), RESULT_NOT_RUN);
54 RecordUMATestResult(static_cast<DiagnosticsTestId>(i), RESULT_NOT_RUN); 58 RecordUMATestResult(static_cast<DiagnosticsTestId>(i), RESULT_NOT_RUN);
55 } 59 }
56 #endif 60 #endif
57 } 61 }
58 62
59 // This entry point is called from early in startup when very few things have 63 // This entry point is called from early in startup when very few things have
60 // been initialized, so be careful what you use. 64 // been initialized, so be careful what you use.
61 int DiagnosticsController::Run(const CommandLine& command_line, 65 int DiagnosticsController::Run(const CommandLine& command_line,
62 DiagnosticsWriter* writer) { 66 DiagnosticsWriter* writer) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 return -1; 98 return -1;
95 } 99 }
96 100
97 writer_ = writer; 101 writer_ = writer;
98 102
99 model_->RecoverAll(writer_); 103 model_->RecoverAll(writer_);
100 return 0; 104 return 0;
101 } 105 }
102 106
103 } // namespace diagnostics 107 } // namespace diagnostics
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/diagnostics/diagnostics_metrics.h » ('j') | chrome/browser/diagnostics/sqlite_diagnostics.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698