Remove recovery diagnostics for the archived history database.

Remove recovery diagnostics for the archived history database.

The reason is that the archived history database feature has been removed as of r275159.

BUG=359377
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281003

[engedy, 2014-06-20 10:02:04]

@Carlos, PTAL.

My previous attempt at this CL (https://codereview.chromium.org/316063003) got
reverted, because the mapping from ID to histogram name -- which I also removed
-- was still used by DiagnosticsController::RecordRegularStartup.

Unfortunately, the framework seems not to allow for easily removing certain
kinds of diagnostics. So now I have re-added the mapping, but I wonder if we
might instead want to make the framework more flexible.

[engedy, 2014-06-20 12:27:28]

On 2014/06/20 10:02:04, engedy wrote:
> @Carlos, PTAL.
> 
> My previous attempt at this CL (https://codereview.chromium.org/316063003) got
> reverted, because the mapping from ID to histogram name -- which I also
removed
> -- was still used by DiagnosticsController::RecordRegularStartup.
> 
> Unfortunately, the framework seems not to allow for easily removing certain
> kinds of diagnostics. So now I have re-added the mapping, but I wonder if we
> might instead want to make the framework more flexible.

Correction: instead of re-adding the mapping, I decided it made more sense to
skip the calls that needed it.

[cpu_(ooo_6.6-7.5), 2014-06-20 13:31:38]

https://codereview.chromium.org/334633006/diff/60001/chrome/browser/diagnosti...
File chrome/browser/diagnostics/sqlite_diagnostics.cc (left):

https://codereview.chromium.org/334633006/diff/60001/chrome/browser/diagnosti...
chrome/browser/diagnostics/sqlite_diagnostics.cc:209: 
How about you rename this factory to include the word obsolete and to return
either null or a no-op object and leave the other things as they are?

[engedy, 2014-06-20 13:37:45]

https://codereview.chromium.org/334633006/diff/60001/chrome/browser/diagnosti...
File chrome/browser/diagnostics/sqlite_diagnostics.cc (left):

https://codereview.chromium.org/334633006/diff/60001/chrome/browser/diagnosti...
chrome/browser/diagnostics/sqlite_diagnostics.cc:209: 
On 2014/06/20 13:31:38, cpu wrote:
> How about you rename this factory to include the word obsolete and to return
> either null or a no-op object and leave the other things as they are?

I initially did not want to go down that path, as it would entail sending back
meaningless UMA histograms. However, I am happy to do it that way if you think
this is an acceptable trade-off.

[cpu_(ooo_6.6-7.5), 2014-06-23 21:49:40]

I rather do that. We only send the prefs when we run the diagnostics.

[engedy, 2014-06-24 08:58:24]

On 2014/06/23 21:49:40, cpu wrote:
> I rather do that. We only send the prefs when we run the diagnostics.

All right, how about this: I have removed almost everything, except sending
baseline histogram values. No special cases is required this way, and the amount
of unused code is minimum.

[cpu_(ooo_6.6-7.5), 2014-06-25 19:28:32]

lgtm

[engedy, 2014-06-25 20:39:53]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:42:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/334633006/80001

[commit-bot: I haz the power, 2014-06-26 00:20:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-26 00:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 00:23:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[engedy, 2014-06-26 07:57:13]

@Alexei: this is re-landing https://codereview.chromium.org/316063003.

It turns out that we are not entirely giving up on the histograms I have marked
as obsolete previously, because supporting that would create a mess on the
client side. Instead, there will be still some minimal (not really informative)
data still reported into them. Shall I still mark them as obsolete?

[Alexei Svitkine (slow), 2014-06-26 13:00:19]

On 2014/06/26 07:57:13, engedy wrote:
> @Alexei: this is re-landing https://codereview.chromium.org/316063003.
> 
> It turns out that we are not entirely giving up on the histograms I have
marked
> as obsolete previously, because supporting that would create a mess on the
> client side. Instead, there will be still some minimal (not really
informative)
> data still reported into them. Shall I still mark them as obsolete?

If you're keeping the code for them, then don't mark them as obsolete.

[engedy, 2014-07-02 09:33:47]

Done, thanks.

[engedy, 2014-07-02 09:33:55]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-07-02 09:34:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/334633006/100001

[commit-bot: I haz the power, 2014-07-02 11:16:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-07-02 11:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 11:23:25]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[engedy, 2014-07-02 11:24:36]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-07-02 11:25:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/334633006/100001

[commit-bot: I haz the power, 2014-07-02 11:28:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-07-02 12:41:30]

Change committed as 281003