Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 334623006: Oilpan: Ensure that types definitions are known for traced weak members. (Closed)

Created:
6 years, 6 months ago by zerny-chromium
Modified:
6 years, 6 months ago
Reviewers:
haraken, sof
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), oilpan-reviews
Project:
blink
Visibility:
Public.

Description

Oilpan: Ensure that types definitions are known for traced weak members. R=sigbjornf@opera.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/platform/heap/Visitor.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zerny-chromium
6 years, 6 months ago (2014-06-18 13:33:59 UTC) #1
zerny-chromium
This change results in a compile assert error for the ExecutionContext bug fixed by https://codereview.chromium.org/344443008/
6 years, 6 months ago (2014-06-18 13:36:11 UTC) #2
sof
nice, lgtm (but a platform/heap/ owner needs to review.)
6 years, 6 months ago (2014-06-18 13:36:28 UTC) #3
haraken
LGTM, thanks!
6 years, 6 months ago (2014-06-18 13:44:24 UTC) #4
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 6 months ago (2014-06-18 13:49:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/334623006/1
6 years, 6 months ago (2014-06-18 13:50:10 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 16:19:28 UTC) #7
Message was sent while issue was closed.
Change committed as 176429

Powered by Google App Engine
This is Rietveld 408576698