Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 334603004: Override HOME dir for gsutil when running on cros device (Closed)

Created:
6 years, 6 months ago by tbarzic
Modified:
6 years, 6 months ago
Reviewers:
achuithb
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Override HOME dir for gsutil when running on cros device Gsutil tries to create a dir (for keeping track of resumable downloads) under home dir. On ChromeOS this is, given that the tests must be run by root, read-only '/root/'. This causes gsutil commands to fail. To avoid this, override HOME dir to writable '/home/chromeos-test'. (this will also require gsuitl to be configured with the same HOME dir) BUG=359293, 386416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278329

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : review feedback #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M tools/telemetry/telemetry/page/cloud_storage.py View 1 2 3 4 5 6 5 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
https://codereview.chromium.org/334603004/diff/60001/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/334603004/diff/60001/tools/telemetry/telemetry/page/cloud_storage.py#newcode27 tools/telemetry/telemetry/page/cloud_storage.py:27: _CROS_GSUTIL_HOME = '/home/chromeos-test/' Rename to _CROS_GSUTIL_HOME_WAR, and add a ...
6 years, 6 months ago (2014-06-19 00:27:39 UTC) #1
tbarzic
https://codereview.chromium.org/334603004/diff/60001/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/334603004/diff/60001/tools/telemetry/telemetry/page/cloud_storage.py#newcode27 tools/telemetry/telemetry/page/cloud_storage.py:27: _CROS_GSUTIL_HOME = '/home/chromeos-test/' On 2014/06/19 00:27:38, achuithb wrote: > ...
6 years, 6 months ago (2014-06-19 00:47:13 UTC) #2
achuithb
lgtm
6 years, 6 months ago (2014-06-19 00:49:27 UTC) #3
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 6 months ago (2014-06-19 00:50:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/334603004/100001
6 years, 6 months ago (2014-06-19 00:54:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:33:01 UTC) #6
Message was sent while issue was closed.
Change committed as 278329

Powered by Google App Engine
This is Rietveld 408576698