QuicStreamSequencer closes the connection on receipt of frames overlapping with buffered data.

QuicStreamSequencer closes the connection on receipt of frames
overlapping with buffered data.

Merge internal change: 68858381

R=rch@chromium.org, rjshade@google.com

[ramant (doing other things), 2014-06-12 02:10:02]

Hi Robbie,
  jar found a small bug with DCHECK (without the following change, it was
crashing in chromium code base).

  lower_bound returns end() if the offset is larger than the highest values
stored in the map. Made a small change to access next_frame->first only if it
not end.

Old code
--------
  FrameMap::const_iterator next_frame =
      buffered_frames_.lower_bound(frame.offset);
  // Duplicate frames should have been dropped in IsDuplicate.
  DCHECK(next_frame->first != frame.offset);


New code
---------

  FrameMap::const_iterator next_frame =
      buffered_frames_.lower_bound(frame.offset);
  // Duplicate frames should have been dropped in IsDuplicate.
  DCHECK(next_frame == buffered_frames_.end() ||
         next_frame->first != frame.offset);

[Robbie Shade, 2014-06-12 13:42:04]

lgtm

Was this caught by a test, or by running a debug Chromium build?

[ramant (doing other things), 2014-06-12 17:12:10]

On 2014/06/12 13:42:04, Robbie Shade wrote:
> lgtm
> 
> Was this caught by a test, or by running a debug Chromium build?

Caught by the debug build of tests. It worked ok on the same machine with the
internal code base's unit tests.

[Ryan Hamilton, 2014-06-12 22:14:40]

lgtm