Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334593005: Removing using declarations that import names in the C++ Standard library. (Closed)

Created:
6 years, 6 months ago by Sunil Ratnu
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, philipj_slow, Rik, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, aandrey+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing using declarations that import names in the C++ Standard library. This is as per the the coding guidelines for blink, which disallows the use of "using" declarations of any kind to import names in the C++ Standard library. This is in continuation of the CL https://codereview.chromium.org/329183002/ Effected Folders: Source/core/html/ BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -67 lines) Patch
M Source/core/html/HTMLAreaElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 9 chunks +10 lines, -12 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/MediaController.cpp View 5 chunks +5 lines, -7 lines 0 comments Download
M Source/core/html/TimeRanges.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/html/forms/BaseDateAndTimeInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/forms/StepRange.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sunil Ratnu
Hi tkent, Please have a look.
6 years, 6 months ago (2014-06-12 14:21:23 UTC) #1
Sunil Ratnu
6 years, 6 months ago (2014-06-12 14:22:28 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-12 23:54:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/334593005/1
6 years, 6 months ago (2014-06-12 23:55:20 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:58:26 UTC) #5
Message was sent while issue was closed. 
Change committed as 176069

Powered by Google App Engine
This is Rietveld 408576698