MacViews: Encapsulate some Aura specifics in widget_unittest.cc

MacViews: Encapsulate some Aura specifics in widget_unittest.cc

This adds a few helper functions to WidgetTest for getting information
from a native widget and makes widget_test.h responsible for defining
typedefs for PlatformNativeWidget and (when not ChromeOS)
PlatformDesktopNativeWidget.

4 aura-specific tests (that are #ifdefd out on ChromeOS) that use
DesktopAuraTopLevelWindowTest are moved from widget/widget_unittest.cc
to widget/desktop_aura/desktop_native_widget_aura_unittest.cc

widget_unittests.cc doesn't yet compile on Mac with this alone due to
the event generator (addressed in CL/322893005).

BUG=378134
TEST=views_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278400

[tapted, 2014-06-18 08:24:12]

rsesek: some mac stuff in widget_test_mac.mm
sky: review/OWNERS

I've split this off from crrev/322893005 which addresses the event generation
part (Andre had an initial look there too). The stuff here is orthogonal.

[Robert Sesek, 2014-06-18 15:20:46]

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
File ui/views/test/widget_test_mac.mm (right):

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
ui/views/test/widget_test_mac.mm:16: [widget->GetNativeWindow() release];
Close the window before destroying it?

[sky, 2014-06-18 17:12:49]

LGTM

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_test.h
File ui/views/test/widget_test.h (right):

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
ui/views/test/widget_test.h:13: # if !defined(OS_CHROMEOS)
no indentation of nested ifdefs.

[tapted, 2014-06-19 02:00:13]

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_test.h
File ui/views/test/widget_test.h (right):

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
ui/views/test/widget_test.h:13: # if !defined(OS_CHROMEOS)
On 2014/06/18 17:12:48, sky wrote:
> no indentation of nested ifdefs.

Done.

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
File ui/views/test/widget_test_mac.mm (right):

https://codereview.chromium.org/334573008/diff/20001/ui/views/test/widget_tes...
ui/views/test/widget_test_mac.mm:16: [widget->GetNativeWindow() release];
On 2014/06/18 15:20:46, rsesek wrote:
> Close the window before destroying it?

Done. yep - the test will need to see the notifications otherwise sent from
~aura::Window() (except here they will eventually be coming via
NSWindowDelegate). I think the ownership model this will be testing is somewhat
analogous to [NSWindow setReleasedWhenClosed], but I haven't plumbed that
through yet. Since ReleasedWhenClosed is default for NSWindow, this is now just
a close with a DCHECK. I'll explore this more deeply when I bring up more of the
widget unittests.

[Robert Sesek, 2014-06-19 13:20:33]

lgtm

[tapted, 2014-06-19 13:39:08]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-06-19 13:40:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/334573008/100001

[commit-bot: I haz the power, 2014-06-19 16:28:45]

Change committed as 278400