Issue 334573007: Integer overflow in fx_basic.h and fx_memory.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334573007: Integer overflow in fx_basic.h and fx_memory.h (Closed)

Created:
6 years, 6 months ago by jun_fang

Modified:
6 years, 5 months ago

Reviewers:
palmer

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -21 lines)			Patch
M	core/include/fxcrt/fx_basic.h	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_memory.h	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_memmgr.cpp	View	1 2	6 chunks	+50 lines, -13 lines	0 comments	Download

Total messages: 4 (0 generated)

jam

Jun: I'm removing myself from all the security reviews, deferring to Chris, thanks.

6 years, 6 months ago (2014-06-19 16:39:38 UTC) #2

jun_fang

6 years, 5 months ago (2014-07-07 20:53:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as rab4221c (presubmit successful).