Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 334573004: Fixes unittests with --enable-text-input-focus-manager flag enabled. (Closed)

Created:
6 years, 6 months ago by Yuki
Modified:
6 years, 6 months ago
Reviewers:
Shu Chen, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, msw
Project:
chromium
Visibility:
Public.

Description

Fixes unittests with --enable-text-input-focus-manager flag enabled. Some unittests get broken when --enable-text-input-focus-manager is enabled. Fixes those tests. BUG=290701 TEST=Run unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277444

Patch Set 1 #

Patch Set 2 : Fixed more unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -37 lines) Patch
M ash/root_window_controller_unittest.cc View 1 3 chunks +15 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/base/ime/input_method_base_unittest.cc View 9 chunks +31 lines, -9 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 5 chunks +42 lines, -8 lines 0 comments Download
M ui/base/ime/mock_input_method.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 6 chunks +15 lines, -4 lines 0 comments Download
M ui/wm/core/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/core/input_method_event_filter_unittest.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yuki
Could you review this CL? I'm now planning to enable --enable-text-input-focus-manager by default, and need ...
6 years, 6 months ago (2014-06-12 14:08:47 UTC) #1
Shu Chen
You may also want to make fixes in: keyboard_unittests: - keyboard_controller_unittest.cc ash_unittests: - workspace_layout_manager_unittest.cc - ...
6 years, 6 months ago (2014-06-13 02:27:42 UTC) #2
Yuki
On 2014/06/13 02:27:42, Shu Chen wrote: > You may also want to make fixes in: ...
6 years, 6 months ago (2014-06-14 08:19:39 UTC) #3
Shu Chen
lgtm
6 years, 6 months ago (2014-06-14 12:52:24 UTC) #4
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 6 months ago (2014-06-15 11:34:30 UTC) #5
Yuki
The CQ bit was unchecked by yukishiino@chromium.org
6 years, 6 months ago (2014-06-15 11:34:31 UTC) #6
Yuki
sky@, could you review this CL as an owner of the following directories? ash/ ui/keyboard/ ...
6 years, 6 months ago (2014-06-16 07:09:43 UTC) #7
sky
LGTM
6 years, 6 months ago (2014-06-16 14:37:05 UTC) #8
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 6 months ago (2014-06-16 15:03:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/334573004/20001
6 years, 6 months ago (2014-06-16 15:04:41 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 15:09:23 UTC) #11
Message was sent while issue was closed.
Change committed as 277444

Powered by Google App Engine
This is Rietveld 408576698