Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 334573002: [Telemetry] Add tabswitching.typical_25 benchmark (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Add tabswitching.typical_25 benchmark “Scotty, we need more power.” BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276679

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jeremy
6 years, 6 months ago (2014-06-11 23:45:30 UTC) #1
tonyg
lgtm https://codereview.chromium.org/334573002/diff/1/tools/perf/benchmarks/tab_switching.py File tools/perf/benchmarks/tab_switching.py (right): https://codereview.chromium.org/334573002/diff/1/tools/perf/benchmarks/tab_switching.py#newcode13 tools/perf/benchmarks/tab_switching.py:13: nit: 2 blank lines between top level definitions. ...
6 years, 6 months ago (2014-06-11 23:46:53 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-12 04:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/334573002/20001
6 years, 6 months ago (2014-06-12 04:17:05 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 14:39:36 UTC) #5
Message was sent while issue was closed.
Change committed as 276679

Powered by Google App Engine
This is Rietveld 408576698