Chromium Code Reviews Chromium Code Reviews
Issue 334533003:
rebaseline_server: delete no-longer-used weightedDiffMeasure (Closed)
Base URL: https://skia.googlesource.com/skia.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Constants used by our imagediff-viewing Javascript code. | 2 * Constants used by our imagediff-viewing Javascript code. |
| 3 */ | 3 */ |
| 4 var module = angular.module( | 4 var module = angular.module( |
| 5 'ConstantsModule', | 5 'ConstantsModule', |
| 6 [] | 6 [] |
| 7 ); | 7 ); |
| 8 | 8 |
| 9 module.constant('constants', (function() { | 9 module.constant('constants', (function() { |
| 10 return { | 10 return { |
| 11 // NOTE: Keep these in sync with ../column.py | 11 // NOTE: Keep these in sync with ../column.py |
| 12 KEY__EXTRACOLUMNHEADERS__HEADER_TEXT: 'headerText', | 12 KEY__EXTRACOLUMNHEADERS__HEADER_TEXT: 'headerText', |
| 13 KEY__EXTRACOLUMNHEADERS__HEADER_URL: 'headerUrl', | 13 KEY__EXTRACOLUMNHEADERS__HEADER_URL: 'headerUrl', |
| 14 KEY__EXTRACOLUMNHEADERS__IS_FILTERABLE: 'isFilterable', | 14 KEY__EXTRACOLUMNHEADERS__IS_FILTERABLE: 'isFilterable', |
| 15 KEY__EXTRACOLUMNHEADERS__IS_SORTABLE: 'isSortable', | 15 KEY__EXTRACOLUMNHEADERS__IS_SORTABLE: 'isSortable', |
| 16 KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS: 'valuesAndCounts', | 16 KEY__EXTRACOLUMNHEADERS__VALUES_AND_COUNTS: 'valuesAndCounts', |
| 17 | 17 |
| 18 // NOTE: Keep these in sync with ../imagediffdb.py | 18 // NOTE: Keep these in sync with ../imagediffdb.py |
| 19 KEY__DIFFERENCES__MAX_DIFF_PER_CHANNEL: 'maxDiffPerChannel', | 19 KEY__DIFFERENCES__MAX_DIFF_PER_CHANNEL: 'maxDiffPerChannel', |
| 20 KEY__DIFFERENCES__NUM_DIFF_PIXELS: 'numDifferingPixels', | 20 KEY__DIFFERENCES__NUM_DIFF_PIXELS: 'numDifferingPixels', |
| 21 KEY__DIFFERENCES__PERCENT_DIFF_PIXELS: 'percentDifferingPixels', | 21 KEY__DIFFERENCES__PERCENT_DIFF_PIXELS: 'percentDifferingPixels', |
| 22 KEY__DIFFERENCES__PERCEPTUAL_DIFF: 'perceptualDifference', | 22 KEY__DIFFERENCES__PERCEPTUAL_DIFF: 'perceptualDifference', |
| 23 KEY__DIFFERENCES__WEIGHTED_DIFF: 'weightedDiffMeasure', | |
|
epoger
2014/06/12 03:35:28
I confirmed that there are no references to this w
| |
| 24 | 23 |
| 25 // NOTE: Keep these in sync with ../imagepair.py | 24 // NOTE: Keep these in sync with ../imagepair.py |
| 26 KEY__IMAGEPAIRS__DIFFERENCES: 'differenceData', | 25 KEY__IMAGEPAIRS__DIFFERENCES: 'differenceData', |
| 27 KEY__IMAGEPAIRS__EXPECTATIONS: 'expectations', | 26 KEY__IMAGEPAIRS__EXPECTATIONS: 'expectations', |
| 28 KEY__IMAGEPAIRS__EXTRACOLUMNS: 'extraColumns', | 27 KEY__IMAGEPAIRS__EXTRACOLUMNS: 'extraColumns', |
| 29 KEY__IMAGEPAIRS__IMAGE_A_URL: 'imageAUrl', | 28 KEY__IMAGEPAIRS__IMAGE_A_URL: 'imageAUrl', |
| 30 KEY__IMAGEPAIRS__IMAGE_B_URL: 'imageBUrl', | 29 KEY__IMAGEPAIRS__IMAGE_B_URL: 'imageBUrl', |
| 31 KEY__IMAGEPAIRS__IS_DIFFERENT: 'isDifferent', | 30 KEY__IMAGEPAIRS__IS_DIFFERENT: 'isDifferent', |
| 32 | 31 |
| 33 // NOTE: Keep these in sync with ../imagepairset.py | 32 // NOTE: Keep these in sync with ../imagepairset.py |
| (...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 72 | 71 |
| 73 // NOTE: Keep these in sync with ../server.py | 72 // NOTE: Keep these in sync with ../server.py |
| 74 KEY__EDITS__MODIFICATIONS: 'modifications', | 73 KEY__EDITS__MODIFICATIONS: 'modifications', |
| 75 KEY__EDITS__OLD_RESULTS_HASH: 'oldResultsHash', | 74 KEY__EDITS__OLD_RESULTS_HASH: 'oldResultsHash', |
| 76 KEY__EDITS__OLD_RESULTS_TYPE: 'oldResultsType', | 75 KEY__EDITS__OLD_RESULTS_TYPE: 'oldResultsType', |
| 77 | 76 |
| 78 // These are just used on the client side, no need to sync with server code. | 77 // These are just used on the client side, no need to sync with server code. |
| 79 KEY__IMAGEPAIRS__ROWSPAN: 'rowspan', | 78 KEY__IMAGEPAIRS__ROWSPAN: 'rowspan', |
| 80 } | 79 } |
| 81 })()) | 80 })()) |
| OLD | NEW |
