Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 334533003: rebaseline_server: delete no-longer-used weightedDiffMeasure (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: delete no-longer-used weightedDiffMeasure (replaced by perceptual diff) NOTRY=True TBR=rmistry Committed: https://skia.googlesource.com/skia/+/984b97c496e3e2d798c1091de4066f495e8afebd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -71 lines) Patch
M gm/rebaseline_server/imagediffdb.py View 5 chunks +0 lines, -37 lines 0 comments Download
M gm/rebaseline_server/imagediffdb_test.py View 2 chunks +6 lines, -8 lines 0 comments Download
M gm/rebaseline_server/imagepair_test.py View 2 chunks +0 lines, -2 lines 0 comments Download
M gm/rebaseline_server/imagepairset_test.py View 2 chunks +0 lines, -2 lines 0 comments Download
M gm/rebaseline_server/static/constants.js View 1 chunk +0 lines, -1 line 1 comment Download
M gm/rebaseline_server/static/view.html View 1 chunk +1 line, -1 line 1 comment Download
M gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json View 5 chunks +5 lines, -9 lines 0 comments Download
M gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json View 6 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
epoger
Committing TBR. Needed this because I am working on a separate CL to stop using ...
6 years, 6 months ago (2014-06-12 03:35:28 UTC) #1
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-12 03:35:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/334533003/1
6 years, 6 months ago (2014-06-12 03:35:53 UTC) #3
commit-bot: I haz the power
Change committed as 984b97c496e3e2d798c1091de4066f495e8afebd
6 years, 6 months ago (2014-06-12 03:36:05 UTC) #4
rmistry
There are references to weightedDiffMeasure in buildbot/cluster_telemetry
6 years, 6 months ago (2014-06-13 12:56:12 UTC) #5
epoger
On 2014/06/13 12:56:12, rmistry wrote: > There are references to weightedDiffMeasure in buildbot/cluster_telemetry OK, I ...
6 years, 6 months ago (2014-06-13 21:17:25 UTC) #6
rmistry
6 years, 6 months ago (2014-06-16 11:36:17 UTC) #7
Message was sent while issue was closed.
On 2014/06/13 21:17:25, epoger wrote:
> On 2014/06/13 12:56:12, rmistry wrote:
> > There are references to weightedDiffMeasure in buildbot/cluster_telemetry
> 
> OK, I took a stab at removing those references in
> https://codereview.chromium.org/330943002/ ('remove all references to
> weightedDiffMeasure from cluster_telemetry code')

Thank you for that CL, I will test it out and make changes, if required, to it.

Powered by Google App Engine
This is Rietveld 408576698