Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334493002: Remove SkPicture pointer from SkPicturePlayback (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SkPicture pointer from SkPicturePlayback This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer. Committed: https://skia.googlesource.com/skia/+/e26e65e8f831f7a5626c92d11bbb8c2cec1f70de

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -171 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 2 chunks +9 lines, -12 lines 2 comments Download
M include/core/SkPicture.h View 2 chunks +1 line, -13 lines 0 comments Download
M src/core/SkPicture.cpp View 1 7 chunks +12 lines, -83 lines 1 comment Download
M src/core/SkPicturePlayback.h View 7 chunks +23 lines, -27 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 12 chunks +40 lines, -34 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-11 20:52:47 UTC) #1
reed1
api lgtm
6 years, 6 months ago (2014-06-11 20:53:47 UTC) #2
mtklein
super mega hyper LGTM !!!! https://codereview.chromium.org/334493002/diff/20001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/334493002/diff/20001/debugger/QT/SkDebuggerGUI.cpp#newcode286 debugger/QT/SkDebuggerGUI.cpp:286: return NULL; This used ...
6 years, 6 months ago (2014-06-11 21:12:59 UTC) #3
robertphillips
https://codereview.chromium.org/334493002/diff/20001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/334493002/diff/20001/debugger/QT/SkDebuggerGUI.cpp#newcode286 debugger/QT/SkDebuggerGUI.cpp:286: return NULL; My thinking on this is that the ...
6 years, 6 months ago (2014-06-12 12:27:30 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-12 12:27:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/334493002/20001
6 years, 6 months ago (2014-06-12 12:28:16 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:51:37 UTC) #7
Message was sent while issue was closed. 
Change committed as e26e65e8f831f7a5626c92d11bbb8c2cec1f70de

Powered by Google App Engine
This is Rietveld 408576698