Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 334463002: Delete MaskImageChanged, VideoChanged, and FullScreenChanged (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Delete MaskImageChanged, VideoChanged, and FullScreenChanged * MaskImageChanged: No one did anything based on this notification. * VideoChanged: There's only want caller and it's simpler to just setNeedsCompositingUpdate, which does the same thing. * FullScreenChanged: No one ever sent this notification. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175972

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M Source/core/rendering/RenderBox.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 17:52:50 UTC) #1
ojan
https://codereview.chromium.org/334463002/diff/1/Source/core/rendering/RenderVideo.cpp File Source/core/rendering/RenderVideo.cpp (right): https://codereview.chromium.org/334463002/diff/1/Source/core/rendering/RenderVideo.cpp#newcode213 Source/core/rendering/RenderVideo.cpp:213: videoElement()->setNeedsCompositingUpdate(); This loses the m_compositedLayerMapping->contentChanged(changeType) call. Is that OK?
6 years, 6 months ago (2014-06-11 18:22:15 UTC) #2
ojan
On 2014/06/11 at 18:22:15, ojan wrote: > https://codereview.chromium.org/334463002/diff/1/Source/core/rendering/RenderVideo.cpp > File Source/core/rendering/RenderVideo.cpp (right): > > https://codereview.chromium.org/334463002/diff/1/Source/core/rendering/RenderVideo.cpp#newcode213 ...
6 years, 6 months ago (2014-06-11 18:22:57 UTC) #3
ojan
lgtm
6 years, 6 months ago (2014-06-11 18:23:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/334463002/1
6 years, 6 months ago (2014-06-11 18:23:57 UTC) #5
commit-bot: I haz the power
Change committed as 175972
6 years, 6 months ago (2014-06-11 19:01:27 UTC) #6
abarth-chromium
6 years, 6 months ago (2014-06-11 19:21:37 UTC) #7
Message was sent while issue was closed.
On 2014/06/11 at 18:22:57, ojan wrote:
> Ah. It looks like that does nothing for this change type.

Correct!

Powered by Google App Engine
This is Rietveld 408576698