Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 334443005: Delete DeprecatedDirtyCompositingDuringCompositingUpdate (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
ojan, blink-reviews, blink-reviews-rendering, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Delete DeprecatedDirtyCompositingDuringCompositingUpdate This CL is a bit of a parlor trick, but it seems worthwhile to remove DeprecatedDirtyCompositingDuringCompositingUpdate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175977

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 3 chunks +4 lines, -41 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 18:34:12 UTC) #1
ojan
Lol. This is what I did in my original patch that you had me undo! ...
6 years, 6 months ago (2014-06-11 18:42:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/334443005/1
6 years, 6 months ago (2014-06-11 18:43:07 UTC) #3
ojan
https://codereview.chromium.org/334443005/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp File Source/core/rendering/compositing/RenderLayerCompositor.cpp (right): https://codereview.chromium.org/334443005/diff/1/Source/core/rendering/compositing/RenderLayerCompositor.cpp#newcode194 Source/core/rendering/compositing/RenderLayerCompositor.cpp:194: enableCompositingModeIfNeeded(); Incidentally, if we were to continue to invest ...
6 years, 6 months ago (2014-06-11 18:44:47 UTC) #4
abarth-chromium
On 2014/06/11 at 18:44:47, ojan wrote: > Incidentally, if we were to continue to invest ...
6 years, 6 months ago (2014-06-11 19:20:57 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 19:39:55 UTC) #6
Message was sent while issue was closed.
Change committed as 175977

Powered by Google App Engine
This is Rietveld 408576698