Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334413005: Outline Element::shouldIgnoreAttributeCase() (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gyuyoung.kim_webkit.org, Nate Chapin, kenneth.christiansen, kouhei+svg_chromium.org, Mike Lawther (Google), pdr., philipj_slow, rjwright, rwlbuis, Stephen Chennney, shans, sof, Steve Block, Timothy Loh, webcomponents-bugzilla_chromium.org
Project:
blink
Visibility:
Public.

Description

Outline Element::shouldIgnoreAttributeCase() This allows the Document.h include to be removed from Element.h, which reduces the amount of recompilation when touching Document.h by about 12%, from 1382 steps to 1214 steps locally. The only place outside of Element.cpp that uses this function is NamedNodeMap::removeNamedItem, which is very rarely used: http://www.chromestatus.com/metrics/feature/timeline/popularity/308 In other words, the performance difference should not matter. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -10 lines) Patch
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/ClassList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLBodyElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMetaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTemplateElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/LinkResource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FormState.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XPathNodeSet.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLeakDetector.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 6 months ago (2014-06-17 12:49:03 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-17 19:27:30 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-17 22:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/334413005/1
6 years, 6 months ago (2014-06-17 22:01:38 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:02:09 UTC) #5
Message was sent while issue was closed. 
Change committed as 176358

Powered by Google App Engine
This is Rietveld 408576698