Issue 334403005: Roll buildtools to fb782d4369d5ae04f17a2fceef7de5a63e50f07b

Issue 334403005: Roll buildtools to fb782d4369d5ae04f17a2fceef7de5a63e50f07b (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 6 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Roll buildtools to fb782d4369d5ae04f17a2fceef7de5a63e50f07b Also add hooks to download clang-format binaries. BUG=none R=machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22036

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -9 lines)			Patch
M	.DEPS.git	View	2 chunks	+56 lines, -3 lines	4 comments	Download
M	DEPS	View	2 chunks	+35 lines, -1 line	0 comments	Download
M	Makefile	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

LGTM with comments: https://codereview.chromium.org/334403005/diff/1/.DEPS.git File .DEPS.git (right): https://codereview.chromium.org/334403005/diff/1/.DEPS.git#newcode33 .DEPS.git:33: '+include', Can't say much to this... ...

6 years, 6 months ago (2014-06-26 09:06:36 UTC) #2

Michael Achenbach

FYI: I think the tryserver is pretty useless at the moment for DEPS changes. It ...

6 years, 6 months ago (2014-06-26 09:07:53 UTC) #3

jochen (gone - plz use gerrit)

https://codereview.chromium.org/334403005/diff/1/.DEPS.git File .DEPS.git (right): https://codereview.chromium.org/334403005/diff/1/.DEPS.git#newcode33 .DEPS.git:33: '+include', On 2014/06/26 09:06:36, Michael Achenbach wrote: > Can't ...

6 years, 6 months ago (2014-06-26 09:47:02 UTC) #4

jochen (gone - plz use gerrit)

6 years, 6 months ago (2014-06-26 10:49:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r22036 (presubmit successful).

Expand Messages | Collapse Messages