Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
334403004:
LeakExpectations: add more serviceworker tests (Closed)
|
Created:
6 years, 6 months ago by kouhei (in TOK) Modified:
6 years, 6 months ago Reviewers:
Dai Mikurube (NOT FULLTIME) CC:
blink-reviews Base URL:
svn://svn.chromium.org/blink/trunk Project:
blink Visibility:
Public. |
DescriptionLeakExpectations: add more serviceworker tests
bonus: sort expectations file
TBR=dmikurube@chromium.org
NOTRY=true
BUG=364390
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176292
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased #Messages
Total messages: 13 (0 generated)
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/334403004/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/LeakExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/LeakExpectations Hunk #1 FAILED at 113. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/LeakExpectations.rej Patch: LayoutTests/LeakExpectations Index: LayoutTests/LeakExpectations diff --git a/LayoutTests/LeakExpectations b/LayoutTests/LeakExpectations index b3714768686c4f9571afc4cd8001fcd20ebe47e3..f7c990edd939a3288c006403c665f9aed6e9089a 100644 --- a/LayoutTests/LeakExpectations +++ b/LayoutTests/LeakExpectations @@ -113,28 +113,29 @@ crbug.com/364390 http/tests/security/isolatedWorld/media-query-wrapper-leaks.htm crbug.com/364390 http/tests/workers/shared-worker-redirect.html [ Leak ] crbug.com/364390 http/tests/xmlhttprequest/workers/shared-worker-response-type-blob-sync.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/activation-after-registration.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-load.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-reload.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/current-on-load.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/current-on-reload.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/fetch-event.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/headermap.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/indexeddb.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/interfaces.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage-msgport-to-client.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage-to-client.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/ready-controlled-document.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration-end-to-end.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration-events.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/response.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request-end-to-end.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/response.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/serviceworkerglobalscope-scope.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/serviceworkerobject-scope.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/state.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/unregister.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-reload.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/fetch-event.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/ready-controlled-document.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request-end-to-end.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-load.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/window-close-during-registration.html [ Leak ] crbug.com/364408 inspector/extensions/extensions-audits-content-script.html [ Leak ] crbug.com/364408 inspector/extensions/extensions-eval-content-script.html [ Leak ]
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/334403004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/LeakExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/LeakExpectations Hunk #1 FAILED at 113. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/LeakExpectations.rej Patch: LayoutTests/LeakExpectations Index: LayoutTests/LeakExpectations diff --git a/LayoutTests/LeakExpectations b/LayoutTests/LeakExpectations index b3714768686c4f9571afc4cd8001fcd20ebe47e3..f7c990edd939a3288c006403c665f9aed6e9089a 100644 --- a/LayoutTests/LeakExpectations +++ b/LayoutTests/LeakExpectations @@ -113,28 +113,29 @@ crbug.com/364390 http/tests/security/isolatedWorld/media-query-wrapper-leaks.htm crbug.com/364390 http/tests/workers/shared-worker-redirect.html [ Leak ] crbug.com/364390 http/tests/xmlhttprequest/workers/shared-worker-response-type-blob-sync.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/activation-after-registration.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-load.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-reload.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/current-on-load.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/current-on-reload.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/fetch-event.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/headermap.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/indexeddb.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/interfaces.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage-msgport-to-client.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage-to-client.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/postmessage.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/ready-controlled-document.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration-end-to-end.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration-events.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/response.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/registration.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request-end-to-end.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/response.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/serviceworkerglobalscope-scope.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/serviceworkerobject-scope.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/state.html [ Leak ] crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/unregister.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-reload.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/fetch-event.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/ready-controlled-document.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request-end-to-end.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/controller-on-load.html [ Leak ] -crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/request.html [ Leak ] +crbug.com/364390 virtual/serviceworker/http/tests/serviceworker/window-close-during-registration.html [ Leak ] crbug.com/364408 inspector/extensions/extensions-audits-content-script.html [ Leak ] crbug.com/364408 inspector/extensions/extensions-eval-content-script.html [ Leak ]
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/334403004/40001
Message was sent while issue was closed.
Change committed as 176292
Message was sent while issue was closed.
lgtm. |
