Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 334403002: Remove unnecessary #includes in update_screen.cc. (Closed)

Created:
6 years, 6 months ago by Sungmann Cho
Modified:
6 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary #includes in update_screen.cc. After the landing https://codereview.chromium.org/212303003, update_screen.cc doesn't need the command line switch related headers anymore. So we can remove these. BUG=349033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/login/screens/update_screen.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 6 months ago (2014-06-17 00:31:39 UTC) #1
Nikita (slow)
lgtm
6 years, 6 months ago (2014-06-18 09:22:19 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 6 months ago (2014-06-18 09:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/334403002/1
6 years, 6 months ago (2014-06-18 09:34:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 15:38:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163704)
6 years, 6 months ago (2014-06-18 15:38:12 UTC) #6
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 6 months ago (2014-06-18 22:00:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/334403002/1
6 years, 6 months ago (2014-06-18 22:01:16 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 00:59:51 UTC) #9
Message was sent while issue was closed.
Change committed as 278208

Powered by Google App Engine
This is Rietveld 408576698