Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 334393008: More SaveFlags removal twiddling. (Closed)

Created:
6 years, 6 months ago by f(malita)
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

More SaveFlags removal twiddling. This is a follow up to https://codereview.chromium.org/338913002/. More tweaks to allow migrating clients to the new API. 1) switch the shim call direction willSave(SaveFlags) -> willSave() (internal users are still using the former, so external overriders of the latter will not be notified otherwise - doh) 2) ensure willSave() stays visible in SkProxyCanvas (Chromium's TimingCanvas attempts to call it explicitly). BUG=skia:2297 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/6ca763f362f25500ffeee0cc0b5dd2b58e9f2a79

Patch Set 1 #

Patch Set 2 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M include/core/SkCanvas.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
f(malita)
6 years, 6 months ago (2014-06-17 20:14:51 UTC) #1
reed1
still fretting over shadow warnings, but lgtm
6 years, 6 months ago (2014-06-17 20:25:05 UTC) #2
f(malita)
On 2014/06/17 20:25:05, reed1 wrote: > still fretting over shadow warnings I think that's what ...
6 years, 6 months ago (2014-06-17 20:35:49 UTC) #3
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 6 months ago (2014-06-17 20:36:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/334393008/20001
6 years, 6 months ago (2014-06-17 20:37:12 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 20:52:21 UTC) #6
Message was sent while issue was closed.
Change committed as 6ca763f362f25500ffeee0cc0b5dd2b58e9f2a79

Powered by Google App Engine
This is Rietveld 408576698