Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334393007: Revert 176213 "DevTools: Load document (html) content from disk ..." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert 176213 "DevTools: Load document (html) content from disk ..." Reverting this change on older branch to refresh dev channel > DevTools: Load document (html) content from disk cache in page agent enabling. > > BUG=354447 > R=pfeldman@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174557 > > Review URL: https://codereview.chromium.org/267393003 TBR=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1040 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/SlowTests View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/resource-tree/main-resource-content.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/resource-tree/main-resource-content-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/resource-tree/resources/main-resource-content-frame.html View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/resource-tree/resources/main-resource-content-frame-utf8.php View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/search/sources-search-scope.html View 1 chunk +0 lines, -143 lines 0 comments Download
D LayoutTests/http/tests/inspector-enabled/search/sources-search-scope-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
A + LayoutTests/http/tests/inspector/resource-tree/resources/main-resource-content-frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/resource-tree/resources/main-resource-content-frame-utf8.php View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/search/sources-search-scope.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/inspector/search/sources-search-scope-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/linkifier.html View 1 chunk +0 lines, -98 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/linkifier-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-1.html View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-1-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-4.html View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-breakpoints-4-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/inspector-enabled/sources/debugger/script-formatter-console-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/linkifier.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/linkifier-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/open-close-open-expected.txt View 2 chunks +4 lines, -15 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-1-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-4.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-breakpoints-4-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-console.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/sources/debugger/script-formatter-console-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 9 chunks +78 lines, -25 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 7 chunks +2 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 16 chunks +15 lines, -84 lines 0 comments Download
D Source/core/inspector/InspectorResourceContentLoader.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-17 18:02:56 UTC) #1
amineer_google
6 years, 6 months ago (2014-06-17 18:03:12 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r176342.

Powered by Google App Engine
This is Rietveld 408576698