Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334393003: Tidy up dependencies for platform/ColorChooser.h (Closed)

Created:
6 years, 6 months ago by lgombos
Modified:
6 years, 6 months ago
Reviewers:
Inactive, eseidel
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Tidy up dependencies for platform/ColorChooser.h Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176386

Patch Set 1 #

Total comments: 2

Patch Set 2 : Forward declare ColorChooser in ColorInputType #

Patch Set 3 : nevermind - wrong CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
ptal
6 years, 6 months ago (2014-06-17 04:50:27 UTC) #1
lgombos
6 years, 6 months ago (2014-06-17 04:50:47 UTC) #2
Inactive
https://codereview.chromium.org/334393003/diff/1/Source/core/html/forms/ColorInputType.h File Source/core/html/forms/ColorInputType.h (right): https://codereview.chromium.org/334393003/diff/1/Source/core/html/forms/ColorInputType.h#newcode35 Source/core/html/forms/ColorInputType.h:35: #include "platform/ColorChooser.h" Can we forward-declare this?
6 years, 6 months ago (2014-06-17 13:56:43 UTC) #3
eseidel
https://codereview.chromium.org/334393003/diff/1/Source/core/html/forms/ColorInputType.h File Source/core/html/forms/ColorInputType.h (right): https://codereview.chromium.org/334393003/diff/1/Source/core/html/forms/ColorInputType.h#newcode35 Source/core/html/forms/ColorInputType.h:35: #include "platform/ColorChooser.h" Yes, we can, but we'd need to ...
6 years, 6 months ago (2014-06-17 21:17:23 UTC) #4
lgombos
Thanks Eric, I made the suggested change.
6 years, 6 months ago (2014-06-18 02:37:28 UTC) #5
eseidel
lgtm
6 years, 6 months ago (2014-06-18 03:18:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/334393003/20001
6 years, 6 months ago (2014-06-18 03:18:58 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 04:30:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 176386

Powered by Google App Engine
This is Rietveld 408576698