Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 334373002: Clear absolute clip rects when transform changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/compositing/overflow/transform-should-update-absolute-clip-rects-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index 041337f6fd6b25e64b4d608d8c43317525dc7f92..748bcf16cd4d33f5bc0fed461f17d82041d6e332 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -504,6 +504,8 @@ void RenderLayer::updateTransform()
// Layers with transforms act as clip rects roots, so clear the cached clip rects here.
m_clipper.clearClipRectsIncludingDescendants();
+ } else if (hasTransform) {
+ m_clipper.clearClipRectsIncludingDescendants(AbsoluteClipRects);
Ian Vollick 2014/06/17 15:57:28 Doesn't this mean that even if we call updateTrans
ajuma 2014/06/17 16:01:50 The caller of updateTransform (RenderLayer::styleC
Ian Vollick 2014/06/17 16:07:25 Ah, thanks. In that case, maybe we could add an AS
ajuma 2014/06/17 17:10:40 Adding an ASSERT is a good idea, but we don't have
}
if (hasTransform) {
« no previous file with comments | « LayoutTests/compositing/overflow/transform-should-update-absolute-clip-rects-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698