Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 334363006: MSE: Allow negative parsed frame PTS/DTS in FrameProcessor (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis
Project:
chromium
Visibility:
Public.

Description

MSE: Allow negative parsed frame PTS/DTS in FrameProcessor r274473 did not remove sanity checks for negative PTS/DTS that occur prior to any adjustment based on timestampOffset. Current MSE spec does not call for issuing decode error if PTS or DTS are negative at the top of the coded frame processing loop. This change removes the sanity checks that are not spec-compliant. R=acolwell@chromium.org BUG=381114 TEST=FrameProcessorTest.AllowNegativeFramePTSAndDTSBeforeOffsetAdjustment Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M media/filters/frame_processor.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wolenetz
acolwell@, PTAL @ PS1. While this fixes the decode error problem reported in http://crbug.com/381114, the ...
6 years, 6 months ago (2014-06-17 02:14:15 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-17 15:26:10 UTC) #2
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-17 17:37:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/334363006/1
6 years, 6 months ago (2014-06-17 17:39:34 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:42:03 UTC) #5
Message was sent while issue was closed.
Change committed as 277903

Powered by Google App Engine
This is Rietveld 408576698