Issue 334353003: Fix LayoutTest that broke on Chrome builds when media attribute logic was removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334353003: Fix LayoutTest that broke on Chrome builds when media attribute logic was removed. (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 6 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix LayoutTest that broke on Chrome builds when media attribute logic was removed. This change removes the "invalid media attribute" case from this test so that it passes on release builds. This test was passing for the wrong reasons on the Chromium waterfall because an error was being generated for MP4 not being supported instead of the invalid attribute. The test URL was changed to an Ogg file so that a supported media type will be used on both the Chrome and Chromium builds. BUG=338197 TESTS=LayoutTests/media/video-source-error-no-candidate.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176296

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	LayoutTests/media/video-source-error-no-candidate.html	View		2 chunks	+3 lines, -4 lines	0 comments	Download
	M	LayoutTests/media/video-source-error-no-candidate-expected.txt	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/334353003/1

6 years, 6 months ago (2014-06-17 07:13:12 UTC) #4

Message was sent while issue was closed.

Change committed as 176296

Expand Messages | Collapse Messages