Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 334353003: Fix LayoutTest that broke on Chrome builds when media attribute logic was removed. (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 6 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix LayoutTest that broke on Chrome builds when media attribute logic was removed. This change removes the "invalid media attribute" case from this test so that it passes on release builds. This test was passing for the wrong reasons on the Chromium waterfall because an error was being generated for MP4 not being supported instead of the invalid attribute. The test URL was changed to an Ogg file so that a supported media type will be used on both the Chrome and Chromium builds. BUG=338197 TESTS=LayoutTests/media/video-source-error-no-candidate.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M LayoutTests/media/video-source-error-no-candidate.html View 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/media/video-source-error-no-candidate-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 6 months ago (2014-06-16 21:48:40 UTC) #1
philipj_slow
Thanks for catching this, LGTM
6 years, 6 months ago (2014-06-17 07:11:55 UTC) #2
philipj_slow
lgtm
6 years, 6 months ago (2014-06-17 07:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/334353003/1
6 years, 6 months ago (2014-06-17 07:13:12 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 08:20:14 UTC) #5
Message was sent while issue was closed.
Change committed as 176296

Powered by Google App Engine
This is Rietveld 408576698