Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 334343002: If managed=False, don't fetch. (Closed)

Created:
6 years, 6 months ago by szager1
Modified:
6 years, 6 months ago
Reviewers:
agable, hinoka
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

If managed=False, don't fetch. This is an issue when bot_update.py is used, and a top-level solution takes a long time to fetch. Without this change, it will be fetched twice. managed=False really means 'hands off my checkout', so gclient should honor that. R=hinoka@chromium.org,agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=277565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -45 lines) Patch
M gclient_scm.py View 2 chunks +7 lines, -5 lines 0 comments Download
M tests/gclient_scm_test.py View 5 chunks +25 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szager1
6 years, 6 months ago (2014-06-16 20:11:30 UTC) #1
agable
lgtm
6 years, 6 months ago (2014-06-16 21:42:27 UTC) #2
szager1
The CQ bit was checked by szager@chromium.org
6 years, 6 months ago (2014-06-16 23:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/334343002/1
6 years, 6 months ago (2014-06-16 23:10:38 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 23:12:33 UTC) #5
Message was sent while issue was closed.
Change committed as 277565

Powered by Google App Engine
This is Rietveld 408576698