tools/gn/ninja_copy_target_writer.cc - Issue 334333005: Add directory extraction to GN path handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_copy_target_writer.cc

Issue 334333005: Add directory extraction to GN path handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge to new file template function Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_copy_target_writer.cc

diff --git a/tools/gn/ninja_copy_target_writer.cc b/tools/gn/ninja_copy_target_writer.cc

index 9ab88e435cbaaba5453f9506ba71a3a9f9739739..4f8534f8edfa3cd2f5208ad18678d9a700510985 100644

--- a/tools/gn/ninja_copy_target_writer.cc

+++ b/tools/gn/ninja_copy_target_writer.cc

@@ -30,7 +30,7 @@ void NinjaCopyTargetWriter::Run() {

// Make the output file from the template.

std::vector<std::string> template_result;

- output_template.ApplyString(input_file.value(), &template_result);

+ output_template.Apply(input_file, &template_result);

CHECK(template_result.size() == 1);

OutputFile output_file(template_result[0]);

« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »