Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 334333005: Add directory extraction to GN path handling. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Add directory extraction to GN path handling. Some of the mojo templates want to put generated files in the directory corresponding to the source file, rather than the directory containing the BUILD file. Previously, this required putting the BUILD files in the same directory. This patch adds the ability to specify the generated file directory corresponding to the input file in the action_foreach file templates so this can be expressed naturally. For parity, it also adds qquerying for this information via get_path_info. BUG= R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278402

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : merge to new file template function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -137 lines) Patch
M tools/gn/command_desc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/file_template.h View 7 chunks +26 lines, -28 lines 0 comments Download
M tools/gn/file_template.cc View 1 2 3 9 chunks +127 lines, -62 lines 0 comments Download
M tools/gn/file_template_unittest.cc View 1 2 chunks +63 lines, -16 lines 0 comments Download
M tools/gn/filesystem_utils.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M tools/gn/function_get_path_info.cc View 1 2 3 5 chunks +45 lines, -3 lines 0 comments Download
M tools/gn/function_get_path_info_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/gn/function_get_target_outputs.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M tools/gn/function_process_file_template.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M tools/gn/ninja_action_target_writer.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_copy_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 6 months ago (2014-06-16 23:51:57 UTC) #1
brettw
Ping?
6 years, 6 months ago (2014-06-18 17:13:38 UTC) #2
cjhopman
lgtm with some small comments about comments https://codereview.chromium.org/334333005/diff/40001/tools/gn/file_template.cc File tools/gn/file_template.cc (right): https://codereview.chromium.org/334333005/diff/40001/tools/gn/file_template.cc#newcode78 tools/gn/file_template.cc:78: " path, ...
6 years, 6 months ago (2014-06-18 18:13:30 UTC) #3
brettw
6 years, 6 months ago (2014-06-19 16:50:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r278402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698