Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 334333004: [webcrypto] exportKey() now returns dictionary when format='jwk' (CL 1 of 2). (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] exportKey() now returns dictionary when format='jwk' (CL 1 of 2). Previously it would return an array buffer of the JSON. This corresponds with the recent spec update: https://dvcs.w3.org/hg/webcrypto-api/rev/f61017a76a5d BUG=373917, 245025 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277884

Patch Set 1 #

Patch Set 2 : rebase, for funzies #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/child/webcrypto/webcrypto_impl.cc View 1 chunk +17 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
eroman
The corresponding blink CL is: https://codereview.chromium.org/338993002/
6 years, 6 months ago (2014-06-16 23:39:13 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/334333004/diff/20001/content/child/webcrypto/webcrypto_impl.cc File content/child/webcrypto/webcrypto_impl.cc (right): https://codereview.chromium.org/334333004/diff/20001/content/child/webcrypto/webcrypto_impl.cc#newcode475 content/child/webcrypto/webcrypto_impl.cc:475: state->buffer.size()); This feels like there's a dependent CL here ...
6 years, 6 months ago (2014-06-17 19:15:20 UTC) #2
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-17 19:27:16 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-17 19:28:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/334333004/20001
6 years, 6 months ago (2014-06-17 19:30:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 22:15:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/163366)
6 years, 6 months ago (2014-06-17 22:15:54 UTC) #7
eroman
6 years, 6 months ago (2014-06-17 22:25:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r277884 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698