Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 334333002: Allow form inputs to be potential cluster roots. (Closed)

Created:
6 years, 6 months ago by skobes
Modified:
6 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Allow form inputs to be potential cluster roots. We check for form inputs in blockSuppressesAutosizing, but the block must be a potential cluster root to reach this check. BUG=376012 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3 lines) Patch
A LayoutTests/fast/text-autosizing/form-controls-textfield-in-span.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/form-controls-textfield-in-span-expected.html View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
skobes
6 years, 6 months ago (2014-06-16 20:02:11 UTC) #1
pdr.
On 2014/06/16 20:02:11, skobes wrote: Tricky catch. LGTM!
6 years, 6 months ago (2014-06-16 20:23:42 UTC) #2
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 6 months ago (2014-06-16 20:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/334333002/1
6 years, 6 months ago (2014-06-16 20:37:13 UTC) #4
commit-bot: I haz the power
Change committed as 176251
6 years, 6 months ago (2014-06-16 22:52:03 UTC) #5
skobes
6 years, 6 months ago (2014-06-19 18:53:32 UTC) #6
Message was sent while issue was closed.
test

Powered by Google App Engine
This is Rietveld 408576698