Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 334323003: Reland r22082 "Replace HeapNumber as doublebox with an explicit MutableHeapNumber." (Closed)

Created:
6 years, 5 months ago by Igor Sheludko
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Reland r22082 "Replace HeapNumber as doublebox with an explicit MutableHeapNumber." R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22129

Patch Set 1 #

Patch Set 2 : Migrations test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -78 lines) Patch
M include/v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 3 chunks +7 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/heap.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/heap.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 6 chunks +14 lines, -1 line 0 comments Download
M src/objects.cc View 12 chunks +23 lines, -8 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 4 chunks +32 lines, -3 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/x87/stub-cache-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A test/mjsunit/migrations.js View 1 1 chunk +311 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 5 months ago (2014-06-30 13:41:17 UTC) #1
Igor Sheludko
I fixed the test. PTAL
6 years, 5 months ago (2014-06-30 15:23:09 UTC) #2
Toon Verwaest
lgtm
6 years, 5 months ago (2014-06-30 15:57:14 UTC) #3
Igor Sheludko
6 years, 5 months ago (2014-07-01 15:03:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698