Issue 334323002: Add null check when accessing WebLocalFrameImpl::mainFrameImpl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334323002: Add null check when accessing WebLocalFrameImpl::mainFrameImpl(). (Closed)

Created:
6 years, 6 months ago by dcheng

Modified:
6 years, 6 months ago

Reviewers:
dglazkov

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Add null check when accessing WebLocalFrameImpl::mainFrameImpl(). The main frame might be null, so we need to check that before trying to dereference it to see if it's a local frame. BUG=385162 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176245

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/web/WebViewImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/334323002/1

6 years, 6 months ago (2014-06-16 19:03:09 UTC) #4

Message was sent while issue was closed.

Change committed as 176245