Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334313002: DevTools: Fix illegal argument types in ViewportControl (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix illegal argument types in ViewportControl R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176302

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/devtools/front_end/ui/ViewportControl.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
apavlov
6 years, 6 months ago (2014-06-16 17:59:00 UTC) #1
lushnikov
https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js File Source/devtools/front_end/ui/ViewportControl.js (right): https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js#newcode322 Source/devtools/front_end/ui/ViewportControl.js:322: selection.setBaseAndExtent(anchorElement || null, anchorOffset, headElement || null, headOffset); Can't ...
6 years, 6 months ago (2014-06-17 08:15:36 UTC) #2
apavlov
https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js File Source/devtools/front_end/ui/ViewportControl.js (right): https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js#newcode322 Source/devtools/front_end/ui/ViewportControl.js:322: selection.setBaseAndExtent(anchorElement || null, anchorOffset, headElement || null, headOffset); On ...
6 years, 6 months ago (2014-06-17 08:27:18 UTC) #3
lushnikov
On 2014/06/17 08:27:18, apavlov wrote: > https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js > File Source/devtools/front_end/ui/ViewportControl.js (right): > > https://codereview.chromium.org/334313002/diff/1/Source/devtools/front_end/ui/ViewportControl.js#newcode322 > ...
6 years, 6 months ago (2014-06-17 08:27:45 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-17 08:28:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/334313002/20001
6 years, 6 months ago (2014-06-17 08:29:46 UTC) #6
apavlov
The CQ bit was unchecked by apavlov@chromium.org
6 years, 6 months ago (2014-06-17 09:33:40 UTC) #7
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-17 09:33:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/334313002/20001
6 years, 6 months ago (2014-06-17 09:33:48 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 10:04:44 UTC) #10
Message was sent while issue was closed. 
Change committed as 176302

Powered by Google App Engine
This is Rietveld 408576698