Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 334283004: Rename DOMWindow to LocalDOMWindow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/Dictionary.cpp
diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp
index 13ba146349abc3d576d1478182048fa7502f6956..2ca672add7dad1c0fa4813cbd407e890032dfeb0 100644
--- a/Source/bindings/v8/Dictionary.cpp
+++ b/Source/bindings/v8/Dictionary.cpp
@@ -317,13 +317,13 @@ bool Dictionary::get(const String& key, unsigned long long& value) const
return true;
}
-bool Dictionary::get(const String& key, RefPtrWillBeMember<DOMWindow>& value) const
+bool Dictionary::get(const String& key, RefPtrWillBeMember<LocalDOMWindow>& value) const
{
v8::Local<v8::Value> v8Value;
if (!getKey(key, v8Value))
return false;
- // We need to handle a DOMWindow specially, because a DOMWindow wrapper
+ // We need to handle a LocalDOMWindow specially, because a LocalDOMWindow wrapper
eseidel 2014/06/17 17:08:11 Are you sure you want to change these?
kenrb 2014/06/17 17:21:47 Not really. I'll change them back on my next rebas
// exists on a prototype chain of v8Value.
value = toDOMWindow(v8Value, m_isolate);
return true;
@@ -524,7 +524,7 @@ bool Dictionary::get(const String& key, RefPtrWillBeMember<EventTarget>& value)
return false;
value = nullptr;
- // We need to handle a DOMWindow specially, because a DOMWindow wrapper
+ // We need to handle a LocalDOMWindow specially, because a LocalDOMWindow wrapper
// exists on a prototype chain of v8Value.
if (v8Value->IsObject()) {
v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(v8Value);

Powered by Google App Engine
This is Rietveld 408576698