Rename DOMWindow to LocalDOMWindow

Rename DOMWindow to LocalDOMWindow

For out-of-process iframes, we require an alternate limited
functionality DOMWindow to be bound to JavaScript window objects.

Renaming DOMWindow to LocalDOMWindow is allows us to later create a
DOMWindow interface class, that is implemented by LocalDOMWindow and
RemoteDOMWindow.

Discussion:
https://groups.google.com/a/chromium.org/d/msg/site-isolation-dev/BC0vAaxCSuM/ChoG4e_lXEYJ

BUG=346764
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176535

[kenrb, 2014-06-16 20:07:36]

Eric: Do you have time to give an opinion on this?

It is a straightforward rename of DOMWindow to LocalDOMWindow. We need to
introduce a RemoteDOMWindow, and we would like to have a common DOMWindow
interface for it (we don't expect that they would share code). V8WindowShell
should be able to handle changing from one to the other.

[eseidel, 2014-06-17 16:59:53]

It's not immediately obvious to me the motivating use cases.  Which places where
callers should be crawling the frame tree and accessing the DOMWindow directly
instead of going through an existing abstraction like RemoteFrame/Frame.

I totally believe that this could be necessary.  Just hoping to limit the
"Remote" API layer as much as possible.

[eseidel, 2014-06-17 17:08:11]

I wonder reading this if we shouldn't leave DOMWindow as "DOMWindowBase" since
99% of callers want LocalDOMWindow.  I know that's different from how we did
Frame/RemoteFrame, but there 99% of callers want the base class Frame.

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Dicti...
File Source/bindings/v8/Dictionary.cpp (right):

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Dicti...
Source/bindings/v8/Dictionary.cpp:326: // We need to handle a LocalDOMWindow
specially, because a LocalDOMWindow wrapper
Are you sure you want to change these?

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Scrip...
File Source/bindings/v8/ScriptController.cpp (right):

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Scrip...
Source/bindings/v8/ScriptController.cpp:367: LocalDOMWindow* window =
frame->domWindow();
This won't be true in the long term, but I presume you'll fix those after you
add DOMWindow back.

[eseidel, 2014-06-17 17:16:00]

In any case, rslgtm the rename.  I would like an rslgtm from either harken or
abarth as well since they have owned the DOMWindow code much more than I these
last few years.

[kenrb, 2014-06-17 17:21:47]

Thanks Eric.

Adam or Kentaro, can one of you please have a look here?

In particular, Eric's comment about the name raises a good question. I have no
problem with leaving this as DOMWindow but other opinions are welcome.

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Dicti...
File Source/bindings/v8/Dictionary.cpp (right):

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Dicti...
Source/bindings/v8/Dictionary.cpp:326: // We need to handle a LocalDOMWindow
specially, because a LocalDOMWindow wrapper
On 2014/06/17 17:08:11, eseidel wrote:
> Are you sure you want to change these?

Not really. I'll change them back on my next rebase.

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Scrip...
File Source/bindings/v8/ScriptController.cpp (right):

https://codereview.chromium.org/334283004/diff/20001/Source/bindings/v8/Scrip...
Source/bindings/v8/ScriptController.cpp:367: LocalDOMWindow* window =
frame->domWindow();
On 2014/06/17 17:08:11, eseidel wrote:
> This won't be true in the long term, but I presume you'll fix those after you
> add DOMWindow back.

ScriptController is the most complicated part of this refactor, because
RemoteFrames won't have one. This came up in the discussion you linked.

[abarth-chromium, 2014-06-17 21:44:36]

On 2014/06/17 at 17:21:47, kenrb wrote:
> Adam or Kentaro, can one of you please have a look here?
> 
> In particular, Eric's comment about the name raises a good question. I have no
problem with leaving this as DOMWindow but other opinions are welcome.

I don't have a strong opinion.  This CL seems consistent with the LocalFrame
name.

[haraken, 2014-06-17 23:46:21]

On 2014/06/17 21:44:36, abarth wrote:
> On 2014/06/17 at 17:21:47, kenrb wrote:
> > Adam or Kentaro, can one of you please have a look here?
> > 
> > In particular, Eric's comment about the name raises a good question. I have
no
> problem with leaving this as DOMWindow but other opinions are welcome.
> 
> I don't have a strong opinion.  This CL seems consistent with the LocalFrame
> name.

I'm fine with LocalDOMWindow/RemoteDOMWindow. LGTM.

[kenrb, 2014-06-18 17:29:39]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-18 17:30:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/60001

[kenrb, 2014-06-18 18:25:17]

The CQ bit was unchecked by kenrb@chromium.org

[kenrb, 2014-06-18 19:05:41]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-18 19:06:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/80001

[commit-bot: I haz the power, 2014-06-18 19:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 19:06:50]

Failed to apply patch for Source/bindings/tests/results/V8TestInterface2.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestInterface2.cpp
  Hunk #1 FAILED at 18.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestInterface2.cpp.rej

Patch:       Source/bindings/tests/results/V8TestInterface2.cpp
Index: Source/bindings/tests/results/V8TestInterface2.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface2.cpp
b/Source/bindings/tests/results/V8TestInterface2.cpp
index
4d166cbda1f70df83946122c3ce1905e84d8ec24..da88868bf17ffbde08e422b2f0226414e8530cbf
100644
--- a/Source/bindings/tests/results/V8TestInterface2.cpp
+++ b/Source/bindings/tests/results/V8TestInterface2.cpp
@@ -18,7 +18,7 @@
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
-#include "core/frame/DOMWindow.h"
+#include "core/frame/LocalDOMWindow.h"
 #include "platform/TraceEvent.h"
 #include "wtf/GetPtr.h"
 #include "wtf/RefPtr.h"

[kenrb, 2014-06-18 20:04:12]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-18 20:04:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/100001

[kenrb, 2014-06-18 20:15:53]

The CQ bit was unchecked by kenrb@chromium.org

[kenrb, 2014-06-18 20:17:39]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-18 20:17:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/120001

[commit-bot: I haz the power, 2014-06-18 22:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 22:12:23]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[kenrb, 2014-06-19 13:11:49]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-19 13:11:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/130001

[commit-bot: I haz the power, 2014-06-19 14:35:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 14:36:00]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[kenrb, 2014-06-19 14:59:44]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-19 15:00:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/150001

[commit-bot: I haz the power, 2014-06-19 18:04:26]

Change committed as 176535