Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 334283004: Rename DOMWindow to LocalDOMWindow (Closed)

Created:
6 years, 6 months ago by kenrb
Modified:
6 years, 6 months ago
CC:
aandrey+blink_chromium.org, alecflett+watch_chromium.org, alecflett, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, caseq+blink_chromium.org, Inactive, cmumford, devtools-reviews_chromium.org, dglazkov+blink, dgrogan, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, ericu+idb_chromium.org, Eric Willigers, eustas+blink_chromium.org, falken, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, kenneth.christiansen, kinuko+fileapi, kinuko+serviceworker, kinuko+worker_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, michaeln, Mike Lawther (Google), nhiroki, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, rune+blink, sergeyv+blink_chromium.org, serviceworker-reviews, shans, sof, site-isolation-reviews_chromium.org, Steve Block, Timothy Loh, tzik, vsevik+blink_chromium.org, watchdog-blink-watchlist_google.com, Yoav Weiss, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Rename DOMWindow to LocalDOMWindow For out-of-process iframes, we require an alternate limited functionality DOMWindow to be bound to JavaScript window objects. Renaming DOMWindow to LocalDOMWindow is allows us to later create a DOMWindow interface class, that is implemented by LocalDOMWindow and RemoteDOMWindow. Discussion: https://groups.google.com/a/chromium.org/d/msg/site-isolation-dev/BC0vAaxCSuM/ChoG4e_lXEYJ BUG=346764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176535

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Rebase #

Patch Set 4 : Another rebase #

Patch Set 5 : Removed conflict markers #

Patch Set 6 : Rebase #

Patch Set 7 : Conflict #

Patch Set 8 : Fixed test breakage #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+609 lines, -2959 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/BindingSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/BindingSecurity.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/Dictionary.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/NPV8Object.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/NPV8Object.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 2 3 4 5 6 7 4 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8NPUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 2 3 4 5 6 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M Source/bindings/v8/npruntime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 8 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 15 chunks +18 lines, -18 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/DOMWindowEventQueue.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/MessageEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/MouseRelatedEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/UIEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/WindowEventContext.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/events/WindowEventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/frame/DOMWindow.h View 1 1 chunk +0 lines, -412 lines 0 comments Download
D Source/core/frame/DOMWindow.cpp View 1 1 chunk +0 lines, -1939 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleNotifier.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleObserver.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/frame/DOMWindowLifecycleObserver.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/frame/DOMWindowProperty.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindowProperty.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/EventHandlerRegistry.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Frame.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/frame/LocalDOMWindow.h View 1 9 chunks +29 lines, -29 lines 0 comments Download
A + Source/core/frame/LocalDOMWindow.cpp View 1 2 3 4 5 6 7 95 chunks +146 lines, -146 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Location.h View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/frame/Location.cpp View 10 chunks +14 lines, -14 lines 0 comments Download
M Source/core/frame/SmartClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/CreateWindow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/CreateWindow.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/DOMWindowPagePopup.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/page/DOMWindowPagePopup.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PointerLockController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/StorageArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/device_light/DeviceLightController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_light/DeviceLightController.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/VideoPlaybackQuality.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/netinfo/NavigatorNetworkInformation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/quota/DOMWindowQuota.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/modules/speech/DOMWindowSpeechSynthesis.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebBindings.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebDOMActivityLogger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
kenrb
Eric: Do you have time to give an opinion on this? It is a straightforward ...
6 years, 6 months ago (2014-06-16 20:07:36 UTC) #1
eseidel
It's not immediately obvious to me the motivating use cases. Which places where callers should ...
6 years, 6 months ago (2014-06-17 16:59:53 UTC) #2
eseidel
I wonder reading this if we shouldn't leave DOMWindow as "DOMWindowBase" since 99% of callers ...
6 years, 6 months ago (2014-06-17 17:08:11 UTC) #3
eseidel
In any case, rslgtm the rename. I would like an rslgtm from either harken or ...
6 years, 6 months ago (2014-06-17 17:16:00 UTC) #4
kenrb
Thanks Eric. Adam or Kentaro, can one of you please have a look here? In ...
6 years, 6 months ago (2014-06-17 17:21:47 UTC) #5
abarth-chromium
On 2014/06/17 at 17:21:47, kenrb wrote: > Adam or Kentaro, can one of you please ...
6 years, 6 months ago (2014-06-17 21:44:36 UTC) #6
haraken
On 2014/06/17 21:44:36, abarth wrote: > On 2014/06/17 at 17:21:47, kenrb wrote: > > Adam ...
6 years, 6 months ago (2014-06-17 23:46:21 UTC) #7
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 17:29:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/60001
6 years, 6 months ago (2014-06-18 17:30:11 UTC) #9
kenrb
The CQ bit was unchecked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 18:25:17 UTC) #10
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 19:05:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/80001
6 years, 6 months ago (2014-06-18 19:06:09 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 19:06:47 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/bindings/tests/results/V8TestInterface2.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-18 19:06:50 UTC) #14
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 20:04:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/100001
6 years, 6 months ago (2014-06-18 20:04:55 UTC) #16
kenrb
The CQ bit was unchecked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 20:15:53 UTC) #17
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-18 20:17:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/120001
6 years, 6 months ago (2014-06-18 20:17:52 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 22:12:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/12460)
6 years, 6 months ago (2014-06-18 22:12:23 UTC) #21
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-19 13:11:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/130001
6 years, 6 months ago (2014-06-19 13:11:57 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 14:35:57 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/967)
6 years, 6 months ago (2014-06-19 14:36:00 UTC) #25
kenrb
The CQ bit was checked by kenrb@chromium.org
6 years, 6 months ago (2014-06-19 14:59:44 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/334283004/150001
6 years, 6 months ago (2014-06-19 15:00:24 UTC) #27
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 18:04:26 UTC) #28
Message was sent while issue was closed.
Change committed as 176535

Powered by Google App Engine
This is Rietveld 408576698