Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334283002: New avatar button: Update when the supervised user ID changes. (Closed)

Created:
6 years, 6 months ago by Marc Treib
Modified:
6 years, 6 months ago
Reviewers:
noms, msw, noms (inactive)
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

New avatar button: Update when the supervised user ID changes. BUG=372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278732

Patch Set 1 #

Patch Set 2 : Mac #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Marc Treib
noms: Please look at c/b/profiles. msw: Please look at c/b/ui.
6 years, 6 months ago (2014-06-18 10:40:17 UTC) #1
msw
lgtm
6 years, 6 months ago (2014-06-18 15:53:49 UTC) #2
noms (inactive)
profiles lgtm
6 years, 6 months ago (2014-06-18 15:56:30 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-18 15:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/334283002/20001
6 years, 6 months ago (2014-06-18 15:59:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 19:30:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/23378) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18523)
6 years, 6 months ago (2014-06-18 19:30:47 UTC) #7
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-20 08:52:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/334283002/60001
6 years, 6 months ago (2014-06-20 08:54:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 14:31:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 15:11:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19817)
6 years, 6 months ago (2014-06-20 15:11:06 UTC) #12
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-20 15:16:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/334283002/60001
6 years, 6 months ago (2014-06-20 15:18:24 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:09:08 UTC) #15
Message was sent while issue was closed. 
Change committed as 278732

Powered by Google App Engine
This is Rietveld 408576698