Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334273003: Move //chrome/common/metrics/proto to //chrome/browser/metrics/variations/proto. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move //chrome/common/metrics/proto to //chrome/browser/metrics/variations/proto. BUG=385920 TEST=None R=isherman@chromium.org,thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280737

Patch Set 1 : #

Total comments: 2

Patch Set 2 : variations_proto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -57 lines) Patch
A + chrome/browser/metrics/variations/proto/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/metrics/variations/proto/chrome_experiments.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/metrics/variations/variations_http_header_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_http_header_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/metrics/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/metrics/proto/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/common/metrics/proto/chrome_experiments.proto View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
tfarina
isherman -> main reviewer thestig -> final approval (for overall chrome/ changes).
6 years, 5 months ago (2014-06-29 19:43:46 UTC) #1
Ilya Sherman
LGTM % a nit. Thanks, Thiago! https://codereview.chromium.org/334273003/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/334273003/diff/20001/chrome/chrome_browser.gypi#newcode3408 chrome/chrome_browser.gypi:3408: 'target_name': 'metrics_proto', nit: ...
6 years, 5 months ago (2014-06-30 21:02:52 UTC) #2
Lei Zhang
lgtm
6 years, 5 months ago (2014-06-30 21:41:47 UTC) #3
tfarina
https://codereview.chromium.org/334273003/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): https://codereview.chromium.org/334273003/diff/20001/chrome/chrome_browser.gypi#newcode3408 chrome/chrome_browser.gypi:3408: 'target_name': 'metrics_proto', On 2014/06/30 21:02:52, Ilya Sherman wrote: > ...
6 years, 5 months ago (2014-07-01 00:20:53 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:57 UTC) #5
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:57 UTC) #6
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:58 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:58 UTC) #8
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:58 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:58 UTC) #10
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-01 00:20:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/334273003/40001
6 years, 5 months ago (2014-07-01 00:22:49 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 02:40:08 UTC) #13
Message was sent while issue was closed. 
Change committed as 280737

Powered by Google App Engine
This is Rietveld 408576698