Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Side by Side Diff: Source/core/css/TreeBoundaryCrossingRules.cpp

Issue 334263020: Refactor SelectorChecker::BehaviorAtBoundary (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 RuleRange ruleRange = collector.matchedResult().ranges.authorRuleRange(); 69 RuleRange ruleRange = collector.matchedResult().ranges.authorRuleRange();
70 70
71 // When comparing rules declared in outer treescopes, outer's rules win. 71 // When comparing rules declared in outer treescopes, outer's rules win.
72 CascadeOrder outerCascadeOrder = size() + size(); 72 CascadeOrder outerCascadeOrder = size() + size();
73 // When comparing rules declared in inner treescopes, inner's rules win. 73 // When comparing rules declared in inner treescopes, inner's rules win.
74 CascadeOrder innerCascadeOrder = size(); 74 CascadeOrder innerCascadeOrder = size();
75 75
76 for (DocumentOrderedList::iterator it = m_scopingNodes.begin(); it != m_scop ingNodes.end(); ++it) { 76 for (DocumentOrderedList::iterator it = m_scopingNodes.begin(); it != m_scop ingNodes.end(); ++it) {
77 const ContainerNode* scopingNode = toContainerNode(*it); 77 const ContainerNode* scopingNode = toContainerNode(*it);
78 CSSStyleSheetRuleSubSet* ruleSubSet = m_treeBoundaryCrossingRuleSetMap.g et(scopingNode); 78 CSSStyleSheetRuleSubSet* ruleSubSet = m_treeBoundaryCrossingRuleSetMap.g et(scopingNode);
79 unsigned boundaryBehavior = SelectorChecker::ScopeContainsLastMatchedEle ment;
80 bool isInnerTreeScope = element->treeScope().isInclusiveAncestorOf(scopi ngNode->treeScope()); 79 bool isInnerTreeScope = element->treeScope().isInclusiveAncestorOf(scopi ngNode->treeScope());
81 80
82 // If a given scoping node is a shadow root, we should use ScopeIsShadow Root.
83 if (scopingNode && scopingNode->isShadowRoot())
84 boundaryBehavior |= SelectorChecker::ScopeIsShadowRoot;
85
86 CascadeOrder cascadeOrder = isInnerTreeScope ? innerCascadeOrder : outer CascadeOrder; 81 CascadeOrder cascadeOrder = isInnerTreeScope ? innerCascadeOrder : outer CascadeOrder;
87 for (CSSStyleSheetRuleSubSet::iterator it = ruleSubSet->begin(); it != r uleSubSet->end(); ++it) { 82 for (CSSStyleSheetRuleSubSet::iterator it = ruleSubSet->begin(); it != r uleSubSet->end(); ++it) {
88 CSSStyleSheet* parentStyleSheet = it->first; 83 CSSStyleSheet* parentStyleSheet = it->first;
89 RuleSet* ruleSet = it->second.get(); 84 RuleSet* ruleSet = it->second.get();
90 collector.collectMatchingRules(MatchRequest(ruleSet, includeEmptyRul es, scopingNode, parentStyleSheet), ruleRange, static_cast<SelectorChecker::Beha viorAtBoundary>(boundaryBehavior), ignoreCascadeScope, cascadeOrder); 85 collector.collectMatchingRules(MatchRequest(ruleSet, includeEmptyRul es, scopingNode, parentStyleSheet), ruleRange, SelectorChecker::ScopeContainsLas tMatchedElement, ignoreCascadeScope, cascadeOrder);
91 } 86 }
92 ++innerCascadeOrder; 87 ++innerCascadeOrder;
93 --outerCascadeOrder; 88 --outerCascadeOrder;
94 } 89 }
95 } 90 }
96 91
97 void TreeBoundaryCrossingRules::reset(const ContainerNode* scopingNode) 92 void TreeBoundaryCrossingRules::reset(const ContainerNode* scopingNode)
98 { 93 {
99 m_treeBoundaryCrossingRuleSetMap.remove(scopingNode); 94 m_treeBoundaryCrossingRuleSetMap.remove(scopingNode);
100 m_scopingNodes.remove(scopingNode); 95 m_scopingNodes.remove(scopingNode);
101 } 96 }
102 97
103 void TreeBoundaryCrossingRules::collectFeaturesFromRuleSubSet(CSSStyleSheetRuleS ubSet* ruleSubSet, RuleFeatureSet& features) 98 void TreeBoundaryCrossingRules::collectFeaturesFromRuleSubSet(CSSStyleSheetRuleS ubSet* ruleSubSet, RuleFeatureSet& features)
104 { 99 {
105 for (CSSStyleSheetRuleSubSet::iterator it = ruleSubSet->begin(); it != ruleS ubSet->end(); ++it) 100 for (CSSStyleSheetRuleSubSet::iterator it = ruleSubSet->begin(); it != ruleS ubSet->end(); ++it)
106 features.add(it->second->features()); 101 features.add(it->second->features());
107 } 102 }
108 103
109 void TreeBoundaryCrossingRules::collectFeaturesTo(RuleFeatureSet& features) 104 void TreeBoundaryCrossingRules::collectFeaturesTo(RuleFeatureSet& features)
110 { 105 {
111 for (TreeBoundaryCrossingRuleSetMap::iterator::Values it = m_treeBoundaryCro ssingRuleSetMap.values().begin(); it != m_treeBoundaryCrossingRuleSetMap.values( ).end(); ++it) 106 for (TreeBoundaryCrossingRuleSetMap::iterator::Values it = m_treeBoundaryCro ssingRuleSetMap.values().begin(); it != m_treeBoundaryCrossingRuleSetMap.values( ).end(); ++it)
112 collectFeaturesFromRuleSubSet(it->get(), features); 107 collectFeaturesFromRuleSubSet(it->get(), features);
113 } 108 }
114 109
115 } // namespace WebCore 110 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698