Fix the vtune support bug.

fix the vtune support bug.

During https://code.google.com/p/v8/source/detail?r=19925 checkin context bound scripts (Script)
and context unbound scripts (UnboundScript) are Distinguished.

And then Sven Panne helped to fix the vtune support compilation
error in https://code.google.com/p/v8/source/detail?r=20955.

The problem is that there is runtime error for vtune
support.
In our original implementation, we encapsulated and passed v8::internal::Script
to V8 API. It will leads to type check error for current V8::Script definition.

So I changed the Handle<Script> definition in JitCodeEvent
to Handle<UnboundScript>
 and add the corresponding change in log.cc.

If you do NOT prefer to change in include/v8.h. I think I can change the definition of
CodeEventLogger::LogRecordedBuffer(...) so that the we can pass the correct
type (JSFunction) as V8::Script to V8 API.


BUG=
R=danno@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22393

[chunyang.dai, 2014-06-26 08:20:08]

hello. Daniel & Marja.
please help to review this patch.
thanks.

[marja, 2014-06-26 11:43:36]

Looks correct to me. UnboundScript is a SharedFunctionInfo. Looks like I
should've done this change in log.cc when I changed the API (as in, the state
after the API change and before this fix is wrong), but there was no test and
nothing broke, so I didn't notice it.

Pls wait for svenpanne@ to verify though.

[Sven Panne, 2014-06-26 12:18:47]

LGTM, I think that the external API change is OK, there are probably not that
many clients of that part of the API. Famous last words... :-}

[chunyang.dai, 2014-06-30 01:47:15]

hello, Daniel.
Could you please help review and port this patch?  And I think it's better that
this patch can be merged to  Branch 3.27 so that this feature support in Chrome
is not broken for a v8 release cycle.
thanks.

[danno, 2014-06-30 09:25:28]

I'm happy to land this in 3.28, but since this is not a critical bug or
performance fix, we won't plan on merging back to 3.27

https://codereview.chromium.org/334263018/diff/1/src/log.cc
File src/log.cc (right):

https://codereview.chromium.org/334263018/diff/1/src/log.cc#newcode673
src/log.cc:673: Handle<SharedFunctionInfo> script_handle;
this variable name is now misleading. Should be shared_function_handle

[chunyang.dai, 2014-07-01 03:18:46]

hi, Daniel.
thanks for review comments. I changed it according to your suggestion.
thanks.

[danno, 2014-07-01 07:12:05]

lgtm. I will land this for you when the tree opens up again.

[danno, 2014-07-15 08:14:13]

Committed patchset #2 manually as r22393 (presubmit successful).